Start using RenderFrameProxyHost objects.

content/browser/frame_host/navigation_controller_impl.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/frame_host/navigation_controller_impl.h"
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/debug/trace_event.h"
 #include "base/logging.h"
@@ skipping 860 matching lines @@
   details->http_status_code = params.http_status_code;
   NotifyNavigationEntryCommitted(details);
 
   return true;
 }
 
 NavigationType NavigationControllerImpl::ClassifyNavigation(
     RenderFrameHost* rfh,
     const FrameHostMsg_DidCommitProvisionalLoad_Params& params) const {
   if (params.page_id == -1) {
+    // FIXME (nasko, creis):  An out-of-process child frame has no way of

[Charlie Reis, 2014/07/24 22:36:29]

We use TODO(...) rather than FIXME in the Chrome repo.

[kenrb, 2014/07/25 23:42:05]

Fixed.

+    // knowing the page_id of its parent, so it is passing back -1. The
+    // semantics here should be re-evaluated during session history refactor.

[Charlie Reis, 2014/07/24 22:36:29]

Can you add a mention of http://crbug.com/236848 to this sentence?

[kenrb, 2014/07/25 23:42:05]

Done.

+    // For now, we assume this means the child frame loaded and proceed.

[Charlie Reis, 2014/07/24 22:36:29]

"Note that this may do the wrong thing for cross-process AUTO_SUBFRAME
navigations."

[kenrb, 2014/07/25 23:42:05]

Done.

+    if (rfh->IsCrossProcessSubframe())
+      return NAVIGATION_TYPE_NEW_SUBFRAME;
+
     // The renderer generates the page IDs, and so if it gives us the invalid
     // page ID (-1) we know it didn't actually navigate. This happens in a few
     // cases:
     //
     // - If a page makes a popup navigated to about blank, and then writes
     //   stuff like a subframe navigated to a real page. We'll get the commit
     //   for the subframe, but there won't be any commit for the outer page.
     //
     // - We were also getting these for failed loads (for example, bug 21849).
     //   The guess is that we get a "load commit" for the alternate error page,
@@ skipping 891 matching lines @@
     }
   }
 }
 
 void NavigationControllerImpl::SetGetTimestampCallbackForTest(
     const base::Callback<base::Time()>& get_timestamp_callback) {
   get_timestamp_callback_ = get_timestamp_callback;
 }
 
 }  // namespace content