Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Issue 404583002: cc: Add layer eviction iterator perftests. (Closed)

Created:
6 years, 5 months ago by vmpstr
Modified:
6 years, 5 months ago
Reviewers:
reveman
CC:
chromium-reviews, cc-bugs_chromium.org
Project:
chromium
Visibility:
Public.

Description

cc: Add layer eviction iterator perftests. This patch adds a construct and a construct and iterate tests for layer level eviction iterators. Initial runs: [ RUN ] PictureLayerImplPerfTest.LayerEvictionTileIteratorConstructAndIterate *RESULT layer_eviction_tile_iterator_construct_and_iterate: 32_100x100= 47900.80859375 runs/s *RESULT layer_eviction_tile_iterator_construct_and_iterate: 32_500x500= 50885.39453125 runs/s *RESULT layer_eviction_tile_iterator_construct_and_iterate: 64_100x100= 49707.58984375 runs/s *RESULT layer_eviction_tile_iterator_construct_and_iterate: 64_500x500= 49089.5078125 runs/s [ OK ] PictureLayerImplPerfTest.LayerEvictionTileIteratorConstructAndIterate (8069 ms) [ RUN ] PictureLayerImplPerfTest.LayerEvictionTileIteratorConstruct *RESULT layer_eviction_tile_iterator_construct: 0_0_100x100= 52248.0390625 runs/s *RESULT layer_eviction_tile_iterator_construct: 5000_0_100x100= 28544.1015625 runs/s *RESULT layer_eviction_tile_iterator_construct: 9999_0_100x100= 29921.828125 runs/s [ OK ] PictureLayerImplPerfTest.LayerEvictionTileIteratorConstruct (6042 ms) R=reveman Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283979

Patch Set 1 #

Total comments: 4

Patch Set 2 : update #

Unified diffs Side-by-side diffs Delta from patch set Stats (+117 lines, -0 lines) Patch
M cc/layers/picture_layer_impl_perftest.cc View 1 3 chunks +117 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
vmpstr
PTAL
6 years, 5 months ago (2014-07-17 19:09:25 UTC) #1
reveman
https://codereview.chromium.org/404583002/diff/1/cc/layers/picture_layer_impl_perftest.cc File cc/layers/picture_layer_impl_perftest.cc (right): https://codereview.chromium.org/404583002/diff/1/cc/layers/picture_layer_impl_perftest.cc#newcode32 cc/layers/picture_layer_impl_perftest.cc:32: const std::vector<Tile*>& tiling_tiles = tiling->AllTilesForTesting(); why "const std::vector<Tile*>&"? doesn't ...
6 years, 5 months ago (2014-07-17 19:30:37 UTC) #2
vmpstr
https://codereview.chromium.org/404583002/diff/1/cc/layers/picture_layer_impl_perftest.cc File cc/layers/picture_layer_impl_perftest.cc (right): https://codereview.chromium.org/404583002/diff/1/cc/layers/picture_layer_impl_perftest.cc#newcode32 cc/layers/picture_layer_impl_perftest.cc:32: const std::vector<Tile*>& tiling_tiles = tiling->AllTilesForTesting(); On 2014/07/17 19:30:36, reveman ...
6 years, 5 months ago (2014-07-17 19:39:13 UTC) #3
reveman
lgtm https://codereview.chromium.org/404583002/diff/1/cc/layers/picture_layer_impl_perftest.cc File cc/layers/picture_layer_impl_perftest.cc (right): https://codereview.chromium.org/404583002/diff/1/cc/layers/picture_layer_impl_perftest.cc#newcode32 cc/layers/picture_layer_impl_perftest.cc:32: const std::vector<Tile*>& tiling_tiles = tiling->AllTilesForTesting(); On 2014/07/17 19:39:13, ...
6 years, 5 months ago (2014-07-17 20:19:28 UTC) #4
vmpstr
https://codereview.chromium.org/404583002/diff/1/cc/layers/picture_layer_impl_perftest.cc File cc/layers/picture_layer_impl_perftest.cc (right): https://codereview.chromium.org/404583002/diff/1/cc/layers/picture_layer_impl_perftest.cc#newcode32 cc/layers/picture_layer_impl_perftest.cc:32: const std::vector<Tile*>& tiling_tiles = tiling->AllTilesForTesting(); On 2014/07/17 20:19:28, reveman ...
6 years, 5 months ago (2014-07-17 20:21:47 UTC) #5
vmpstr
The CQ bit was checked by vmpstr@chromium.org
6 years, 5 months ago (2014-07-17 20:21:50 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vmpstr@chromium.org/404583002/20001
6 years, 5 months ago (2014-07-17 20:24:44 UTC) #7
commit-bot: I haz the power
6 years, 5 months ago (2014-07-18 02:43:40 UTC) #8
Message was sent while issue was closed.
Change committed as 283979

Powered by Google App Engine
This is Rietveld 408576698