Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 404563003: Add MediaQueryListEvent. Not used yet. (Closed)

Created:
6 years, 5 months ago by cbiesinger
Modified:
6 years, 4 months ago
Reviewers:
haraken, esprehn
CC:
blink-reviews, kenneth.christiansen, Yoav Weiss, arv+blink, blink-reviews-css, eae+blinkwatch, ed+blinkwatch_opera.com, blink-reviews-events_chromium.org, dglazkov+blink, apavlov+blink_chromium.org, Inactive, darktears, rwlbuis, rune+blink
Project:
blink
Visibility:
Public.

Description

Add MediaQueryListEvent. Not used yet. This will be for https://codereview.chromium.org/396283004/ BUG=375658

Patch Set 1 #

Patch Set 2 : also need webexposed/global-constructors-listing-expected.txt #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -3 lines) Patch
M LayoutTests/virtual/stable/webexposed/global-constructors-listing-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/webexposed/global-constructors-listing-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/core.gypi View 3 chunks +3 lines, -0 lines 0 comments Download
A Source/core/css/MediaQueryListEvent.h View 1 chunk +71 lines, -0 lines 0 comments Download
A + Source/core/css/MediaQueryListEvent.idl View 1 chunk +5 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
cbiesinger
6 years, 5 months ago (2014-07-17 19:31:56 UTC) #1
haraken
As commented in https://codereview.chromium.org/396283004/#msg9, let's split a CL into pieces so that each piece is ...
6 years, 5 months ago (2014-07-18 01:17:15 UTC) #2
esprehn
On 2014/07/18 at 01:17:15, haraken wrote: > As commented in https://codereview.chromium.org/396283004/#msg9, let's split a CL ...
6 years, 4 months ago (2014-08-01 14:10:08 UTC) #3
cbiesinger
6 years, 4 months ago (2014-08-06 23:27:57 UTC) #4
On 2014/08/01 14:10:08, esprehn wrote:
> On 2014/07/18 at 01:17:15, haraken wrote:
> > As commented in https://codereview.chromium.org/396283004/#msg9, let's split
a
> CL into pieces so that each piece is actually used and has a test case.
> 
> How's this going?

I couldn't think of a way to do that :(

Powered by Google App Engine
This is Rietveld 408576698