Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1601)

Issue 404553008: Rename autofill_download.{cc,h} to autofill_download_manager.{cc,h}. (Closed)

Created:
6 years, 5 months ago by Ilya Sherman
Modified:
6 years, 5 months ago
Reviewers:
Evan Stade
CC:
chromium-reviews, benquan, browser-components-watch_chromium.org, Dane Wallinga, dyu1, estade+watch_chromium.org, Ilya Sherman, rouslan+autofillwatch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Rename autofill_download.{cc,h} to autofill_download_manager.{cc,h}. The file names now match the class name. BUG=none TEST=none R=estade@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284631

Patch Set 1 #

Patch Set 2 : Fix GN build #

Patch Set 3 : Fix GN build (again) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -1007 lines) Patch
M components/autofill.gypi View 1 chunk +2 lines, -2 lines 0 comments Download
M components/autofill/core/browser/BUILD.gn View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
D components/autofill/core/browser/autofill_download.h View 1 chunk +0 lines, -169 lines 0 comments Download
D components/autofill/core/browser/autofill_download.cc View 1 chunk +0 lines, -330 lines 0 comments Download
A + components/autofill/core/browser/autofill_download_manager.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/autofill/core/browser/autofill_download_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/autofill/core/browser/autofill_download_manager_unittest.cc View 1 2 2 chunks +2 lines, -1 line 0 comments Download
D components/autofill/core/browser/autofill_download_unittest.cc View 1 2 1 chunk +0 lines, -496 lines 0 comments Download
M components/autofill/core/browser/autofill_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M components/components_tests.gyp View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (0 generated)
Ilya Sherman
6 years, 5 months ago (2014-07-18 23:56:16 UTC) #1
Evan Stade
lgtm
6 years, 5 months ago (2014-07-19 01:22:13 UTC) #2
Ilya Sherman
The CQ bit was checked by isherman@chromium.org
6 years, 5 months ago (2014-07-19 02:36:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/isherman@chromium.org/404553008/1
6 years, 5 months ago (2014-07-19 02:39:05 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_gn_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-19 04:26:12 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-19 04:32:04 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel/builds/27489)
6 years, 5 months ago (2014-07-19 04:32:05 UTC) #7
Ilya Sherman
The CQ bit was checked by isherman@chromium.org
6 years, 5 months ago (2014-07-21 22:14:18 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/isherman@chromium.org/404553008/20001
6 years, 5 months ago (2014-07-21 22:14:58 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_gn_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-22 01:40:03 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-22 01:47:47 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel/builds/27921)
6 years, 5 months ago (2014-07-22 01:47:48 UTC) #12
Ilya Sherman
The CQ bit was checked by isherman@chromium.org
6 years, 5 months ago (2014-07-22 03:21:51 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/isherman@chromium.org/404553008/40001
6 years, 5 months ago (2014-07-22 03:22:56 UTC) #14
commit-bot: I haz the power
6 years, 5 months ago (2014-07-22 05:05:14 UTC) #15
Message was sent while issue was closed.
Change committed as 284631

Powered by Google App Engine
This is Rietveld 408576698