Issue 404553007: Fix array index in test initialization.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 404553007: Fix array index in test initialization. (Closed)

Created:
6 years, 5 months ago by wala

Modified:
6 years, 5 months ago

Reviewers:
Jim Stichnoth

CC:
native-client-reviews_googlegroups.com

Base URL:
https://gerrit.chromium.org/gerrit/p/native_client/pnacl-subzero.git@master

Visibility:
Public.

More Reviews

Description

Fix array index in test initialization. Index() % NumElementsInType should be Index() % NumValues. BUG=none R=stichnot@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=35ec373

Patch Set 2 : Push Values and NumValues to testsInt() and testsVecInt(). #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -7 lines)			Patch
	M	crosstest/test_arith_main.cpp	View	1	5 chunks	+8 lines, -7 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Jim Stichnoth

LGTM with one extra request. https://codereview.chromium.org/404553007/diff/1/crosstest/test_arith_main.cpp File crosstest/test_arith_main.cpp (right): https://codereview.chromium.org/404553007/diff/1/crosstest/test_arith_main.cpp#newcode22 crosstest/test_arith_main.cpp:22: volatile unsigned Values[] = ...

6 years, 5 months ago (2014-07-18 22:50:35 UTC) #2

wala

On 2014/07/18 22:50:35, stichnot wrote: > LGTM with one extra request. > > https://codereview.chromium.org/404553007/diff/1/crosstest/test_arith_main.cpp > ...

6 years, 5 months ago (2014-07-18 23:31:42 UTC) #3

wala

6 years, 5 months ago (2014-07-18 23:32:20 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r35ec373 (presubmit successful).

Expand Messages | Collapse Messages

Issue 404553007: Fix array index in test initialization. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Push Values and NumValues to testsInt() and testsVecInt(). #

Messages