tools/android/adb_profile_chrome/perf_controller_unittest.py - Issue 404543003: adb_profile_chrome: Check in perf-to-tracing conversion script

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/android/adb_profile_chrome/perf_controller_unittest.py

Issue 404543003: adb_profile_chrome: Check in perf-to-tracing conversion script (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/android/adb_profile_chrome/perf_controller_unittest.py

diff --git a/tools/android/adb_profile_chrome/perf_controller_unittest.py b/tools/android/adb_profile_chrome/perf_controller_unittest.py

index eac12eba63028e26204d89ebac7ad1c90d83bd3a..09aaf3d1920bf4f0b00a22db1603e79cd7fc10df 100644

--- a/tools/android/adb_profile_chrome/perf_controller_unittest.py

+++ b/tools/android/adb_profile_chrome/perf_controller_unittest.py

@@ -35,14 +35,6 @@ class PerfProfilerControllerTest(controllers_unittest.BaseControllerTest):

controller.StopTracing()

result = controller.PullTrace()

- # Perf-to-JSON conversion can fail if dependencies are missing.

- if not result:

- perf_script_path = os.path.join(constants.DIR_SOURCE_ROOT,

- 'tools', 'telemetry', 'telemetry', 'core', 'platform', 'profiler',

- 'perf_vis', 'perf_to_tracing.py')

- assert not os.path.exists(perf_script_path)

- return

try:

with open(result) as f:

json.loads(f.read())