Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 404483002: Revert of "Blink does not respect input.selectionStart and input.selectionEnd for some cases" (Closed)

Created:
6 years, 5 months ago by tkent
Modified:
6 years, 5 months ago
Reviewers:
CC:
blink-reviews, blink-reviews-html_chromium.org, dglazkov+blink, dmazzoni, aboxhall
Project:
blink
Visibility:
Public.

Description

Revert of "Blink does not respect input.selectionStart and input.selectionEnd for some cases" r177724 https://codereview.chromium.org/258063005 Revert of "Auto-rebaseline for r177724" r177733 https://codereview.chromium.org/376183003 Reason for revert: r177724 caused multiple regressions. TBR=harpreet.sk@samsung.com NOTRY=true BUG=133242, 367736, 393148, 393168 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178327

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -83 lines) Patch
M LayoutTests/accessibility/textarea-insertion-point-line-number.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/accessibility/textarea-insertion-point-line-number-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/editing/deleting/5290534.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/editing/inserting/4960120-1.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/editing/pasteboard/paste-removing-iframe.html View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/editing/pasteboard/pasting-tabs.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/editing/selection/5497643.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/forms/input-placeholder-visibility-2-expected.html View 1 chunk +0 lines, -1 line 0 comments Download
D LayoutTests/fast/forms/input-set-selectionStart-set-selectionEnd.html View 1 chunk +0 lines, -33 lines 0 comments Download
D LayoutTests/fast/forms/input-set-selectionStart-set-selectionEnd-expected.txt View 1 chunk +0 lines, -17 lines 0 comments Download
M LayoutTests/fast/forms/input-setvalue-selection.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/forms/paste-into-textarea.html View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/forms/textarea-arrow-navigation.html View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/forms/validationMessage.html View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/platform/linux/fast/repaint/subtree-root-skipped-expected.txt View 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/platform/mac/fast/repaint/subtree-root-skipped-expected.txt View 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/platform/win-xp/fast/repaint/subtree-root-skipped-expected.txt View 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/platform/win/fast/repaint/subtree-root-skipped-expected.txt View 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/html/HTMLTextFormControlElement.cpp View 3 chunks +9 lines, -16 lines 0 comments Download
M Source/core/html/forms/TextFieldInputType.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
tkent
The CQ bit was checked by tkent@chromium.org
6 years, 5 months ago (2014-07-17 05:24:24 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/404483002/1
6 years, 5 months ago (2014-07-17 05:25:36 UTC) #2
commit-bot: I haz the power
6 years, 5 months ago (2014-07-17 05:48:15 UTC) #3
Message was sent while issue was closed. 
Change committed as 178327

Powered by Google App Engine
This is Rietveld 408576698