DescriptionRevert of Added wrapper test class for touch_exploration_controller. (https://codereview.chromium.org/386043002/)
Reason for revert:
Causes LSAN errors on CrOS: http://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%283%29/builds/2299/steps/ui_unittests/logs/DoubleTap
e.g.
Indirect leak of 2904 byte(s) in 1 object(s) allocated from:
#0 0x44edfb in operator new(unsigned long) /usr/local/google/work/chromium/src/third_party/llvm/projects/compiler-rt/lib/asan/asan_new_delete.cc:55
#1 0x9fbc47 in CreateStrategy ui/events/gesture_detection/velocity_tracker.cc:201
#2 0x9fbc47 in ui::VelocityTracker::VelocityTracker(ui::VelocityTracker::Strategy) ui/events/gesture_detection/velocity_tracker.cc:234
#3 0x9fa322 in ui::VelocityTrackerState::VelocityTrackerState() ui/events/gesture_detection/velocity_tracker_state.cc:18
#4 0x9f5d64 in ui::GestureDetector::GestureDetector(ui::GestureDetector::Config const&, ui::GestureDetector::GestureListener*, ui::GestureDetector::DoubleTapListener*) ui/events/gesture_detection/gesture_detector.cc:191
#5 0x1431ddf in GestureListenerImpl ui/events/gesture_detection/gesture_provider.cc:296
#6 0x1431ddf in ui::GestureProvider::InitGestureDetectors(ui::GestureProvider::Config const&) ui/events/gesture_detection/gesture_provider.cc:629
#7 0x142ebdd in ui::FilteredGestureProvider::FilteredGestureProvider(ui::GestureProvider::Config const&, ui::GestureProviderClient*) ui/events/gesture_detection/filtered_gesture_provider.cc:19
#8 0x1410cd3 in ui::GestureProviderAura::GestureProviderAura(ui::GestureProviderAuraClient*) ui/events/gestures/gesture_provider_aura.cc:19
#9 0x9e9bcd in ui::TouchExplorationController::TouchExplorationController(aura::Window*) ui/chromeos/touch_exploration_controller.cc:33
#10 0x663c47 in ui::TouchExplorationTest::SwitchTouchExplorationMode(bool) ui/chromeos/touch_exploration_controller_unittest.cc:214
#11 0x674532 in ui::TouchExplorationTest_DoubleTap_Test::TestBody() ui/chromeos/touch_exploration_controller_unittest.cc:563
#12 0x7babc8 in HandleExceptionsInMethodIfSupported\u003Ctesting::Test, void> testing/gtest/src/gtest.cc:2045
#13 0x7babc8 in testing::Test::Run() testing/gtest/src/gtest.cc:2061
#14 0x7bcd08 in testing::TestInfo::Run() testing/gtest/src/gtest.cc:2237
#15 0x7bda46 in testing::TestCase::Run() testing/gtest/src/gtest.cc:2344
#16 0x7d072a in testing::internal::UnitTestImpl::RunAllTests() testing/gtest/src/gtest.cc:4065
#17 0x7cfd70 in HandleExceptionsInMethodIfSupported\u003Ctesting::internal::UnitTestImpl, bool> testing/gtest/src/gtest.cc:2045
#18 0x7cfd70 in testing::UnitTest::Run() testing/gtest/src/gtest.cc:3697
#19 0x7770b4 in RUN_ALL_TESTS testing/gtest/include/gtest/gtest.h:2231
#20 0x7770b4 in base::TestSuite::Run() base/test/test_suite.cc:227
#21 0x76e0c1 in Run base/callback.h:401
#22 0x76e0c1 in base::(anonymous namespace)::LaunchUnitTestsInternal(base::Callback\u003Cint ()> const&, int, bool, base::Callback\u003Cvoid ()> const&) base/test/launcher/unit_test_launcher.cc:498
#23 0x76da5c in base::LaunchUnitTests(int, char**, base::Callback\u003Cint ()> const&) base/test/launcher/unit_test_launcher.cc:553
#24 0x59cfaa in main ui/base/test/run_all_unittests.cc:105
#25 0x7fd0195b276c in __libc_start_main /build/buildd/eglibc-2.15/csu/libc-start.c:226
Original issue's description:
> Added wrapper test class for touch_exploration_controller.
> Wrapper class is currently located in the unittest file and is a friend of touch_exploration_controller.
>
> BUG=377040
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283741
TBR=aboxhall@chromium.org,dmazzoni@chromium.org,evy@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=377040
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283811
Patch Set 1 #
Created: 6 years, 5 months ago
(Patch set is too large to download)
Messages
Total messages: 4 (0 generated)
|