Issue 404473003: Remove ASSERT(map.size() == isolatedWorldCount) from DOMWrapperWorld.cpp

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 404473003: Remove ASSERT(map.size() == isolatedWorldCount) from DOMWrapperWorld.cpp (Closed)

Created:
6 years, 5 months ago by haraken

Modified:
6 years, 5 months ago

Reviewers:
vsevik

CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink, abarth-chromium

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

Remove ASSERT(map.size() == isolatedWorldCount) from DOMWrapperWorld.cpp Now that we have a private script isolated world, map.size() is not guaranteed to be equal to isolatedWorldCount(). We can just remove the ASSERT (rather than inventing a more complicated ASSERT condition). BUG=394230 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178362

Patch Set 1 #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -3 lines)			Patch
	M	Source/bindings/core/v8/DOMWrapperWorld.cpp	View		2 chunks	+0 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haraken@chromium.org/404473003/1

6 years, 5 months ago (2014-07-17 11:10:45 UTC) #3

Message was sent while issue was closed.

Change committed as 178362

Expand Messages | Collapse Messages