Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Unified Diff: Tools/GardeningServer/ui/ct-failure-card.html

Issue 404463003: Move commit list and builder latest revisions up to ct-unexpected-failures (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: address review comments Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Tools/GardeningServer/ui/ct-failure-analyzer.html ('k') | Tools/GardeningServer/ui/ct-failure-stream.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Tools/GardeningServer/ui/ct-failure-card.html
diff --git a/Tools/GardeningServer/ui/ct-failure-card.html b/Tools/GardeningServer/ui/ct-failure-card.html
index faa03241878a5800e5db1fbefe330246958d51c1..596f7ac3d64d1362f68e7e236b349f224fa8a7f3 100644
--- a/Tools/GardeningServer/ui/ct-failure-card.html
+++ b/Tools/GardeningServer/ui/ct-failure-card.html
@@ -8,7 +8,7 @@ found in the LICENSE file.
<link rel="import" href="ct-commit-list.html">
<link rel="import" href="ct-test-list.html">
-<polymer-element name="ct-failure-card" attributes="failures">
+<polymer-element name="ct-failure-card" attributes="failures builderLatestRevisions commits">
<template>
<style>
:host {
@@ -55,17 +55,20 @@ found in the LICENSE file.
align-self: flex-start;
}
</style>
- <ct-builder-grid failures="{{failures}}"></ct-builder-grid>
+ <ct-builder-grid failures="{{failures}}" builderLatestRevisions="{{builderLatestRevisions}}"></ct-builder-grid>
<div class="failure">
<ct-test-list tests="{{failures|testNames}}"></ct-test-list>
<ct-commit-list first="{{failures[0].newestPassingRevision + 1}}"
- last="{{failures[0].oldestFailingRevision}}"></ct-commit-list>
+ last="{{failures[0].oldestFailingRevision}}"
+ commits="{{commits}}"></ct-commit-list>
</div>
<paper-button id="examine" on-tap="{{examine}}">Examine</paper-button>
</template>
<script>
Polymer({
failures: [],
+ builderLatestRevisions: {},
+ commits: {},
testNames: function(failures) {
return failures.map(function(failureAnalysis) { return failureAnalysis.testName }).sort();
« no previous file with comments | « Tools/GardeningServer/ui/ct-failure-analyzer.html ('k') | Tools/GardeningServer/ui/ct-failure-stream.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698