Move commit list and builder latest revisions up to ct-unexpected-failures

Tools/GardeningServer/model/ct-commit-log.html

Index: Tools/GardeningServer/model/ct-commit-log.html
diff --git a/Tools/GardeningServer/model/ct-commit-log.html b/Tools/GardeningServer/model/ct-commit-log.html
new file mode 100644
index 0000000000000000000000000000000000000000..a860adfa908f72b010df315ee9f62e163943427e
--- /dev/null
+++ b/Tools/GardeningServer/model/ct-commit-log.html
@@ -0,0 +1,36 @@
+<!--
+Copyright 2014 The Chromium Authors. All rights reserved.
+Use of this source code is governed by a BSD-style license that can be
+found in the LICENSE file.
+-->
+
+<link rel='import' href='ct-commit.html'>
+
+<script>
+function CTCommitLog() {
+  // FIXME: This should be a map of repo-name to revision log using the same
+  // repo names that auto-sheriff.appspot's json uses.
+
+  // FIXME: Use better feeds.
+  // https://chromium.googlesource.com/chromium/blink/+log/master?format=json
+  // https://chromium.googlesource.com/chromium/chromium/+log/master?format=json
+  // https://code.google.com/feeds/p/skia/svnchanges/basic
+  // https://code.google.com/feeds/p/v8/svnchanges/basic
+  // https://code.google.com/feeds/p/nativeclient/svnchanges/basic
+  this.commits = {};
+}
+
+CTCommitLog.prototype.update = function() {
+  // FIXME: Turn net.js into net.html and import it at the top of this file.
+  return net.xml('http://blink.lc/blink/atom').then(this._processXml.bind(this));
+}
+
+CTCommitLog.prototype._processXml = function(xml) {

[abarth-chromium, 2014/07/21 06:36:26]

_processXml -> _processXML ?

[ojan, 2014/07/21 19:58:04]

I really dislike that style. That's how to get abominations like XMLHttpRequest.
XMLHTTPRequest.

+  Array.prototype.forEach.call(xml.getElementsByTagName('entry'), function(logentry) {

[michaelpg, 2014/07/21 07:28:48]

nit: can we keep to an 80-char line length?

Array.prototype.forEach.call(xml.getElementsByTagName('entry'),
                                                      function(logentry) {
  ...

[ojan, 2014/07/21 19:58:04]

I'm not a huge fan of our hybrid blink/chromium style we're using for this
rewrite (blinks lack of a line-length limit and chromiums 2-space indent). I
blame abarth. That said, the rest of the code doesn't do 80 chars, so I'm not
inclined to do so.

+    var author = logentry.getElementsByTagName('author')[0].textContent.trim();
+    var message = logentry.getElementsByTagName('content')[0].textContent;

[abarth-chromium, 2014/07/21 06:36:26]

Why trim the author but not the message?

[ojan, 2014/07/21 19:58:04]

This was just copy-paste from the old code. I didn't even notice the trimming of
author. What's funny is that message is trimmed in CTCommit. Will fix to just
trim up here.

+    var commit = new CTCommit(author, message);
+    this.commits[commit.revision] = commit;
+  }.bind(this));
+}
+</script>