Move commit list and builder latest revisions up to ct-unexpected-failures

Tools/GardeningServer/model/ct-commit.html

+<!--
+Copyright 2014 The Chromium Authors. All rights reserved.
+Use of this source code is governed by a BSD-style license that can be
+found in the LICENSE file.
+-->
+
+<script>
+function CTCommit(author, message) {

[ojan, 2014/07/19 02:02:57]

This is a hugely simplified from svn-log.js. I didn't see the point in
supporting a bunch of effectively dead code.

[abarth-chromium, 2014/07/21 06:36:27]

That's fine.

+  this.author = author;
+  this.message = message.trim();

[abarth-chromium, 2014/07/21 06:36:27]

I see, we do the trimming in different layers...  Seems like we should be
consistent.

[ojan, 2014/07/21 19:58:04]

Fixed.

+  this.revision = this._findRevision();

[michaelpg, 2014/07/21 07:28:48]

this._findRevision(this.message)?

[ojan, 2014/07/21 19:58:04]

Whoops. I forgot to remove the message argument to findRevision.

+  this.summary = this.message.split('\n')[0];

[michaelpg, 2014/07/21 07:28:48]

Are these messages always reasonable sizes or might there be a ton of lines?

[ojan, 2014/07/21 19:58:04]

They're whatever size the commit description is. This is a silly way to grab the
first line. I just landed on this because I started with complicated svn-log.js
code and didn't notice I ended up with something silly. I put a FIXME to use
indexOf/substring for now since I don't want to create conflicts for
https://codereview.chromium.org/402603007.

+}
+
+CTCommit.prototype._findRevision = function(message) {
+  var regexp = /git-svn-id: svn:\/\/svn.chromium.org\/blink\/trunk@(\d+)/;

[abarth-chromium, 2014/07/21 06:36:27]

This isn't very general...

[ojan, 2014/07/21 19:58:04]

Didn't even notice this. Copy-pasta from the old code. Added FIXME for now.

+  var match = regexp.exec(this.message);
+  if (match)
+    return parseInt(match[1], 10);
+  return null;
+}
+</script>