Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 404443008: [Mac] Fix the alignment of the new avatar button and the bubble. (Closed)

Created:
6 years, 5 months ago by noms (inactive)
Modified:
6 years, 5 months ago
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

[Mac] Fix the alignment of the new avatar button and the bubble. Before: https://drive.google.com/file/d/0B1B1Up4p2NRMLTQ1ZFc0blIwbzA/edit?usp=sharing After: https://drive.google.com/file/d/0B1B1Up4p2NRMVUloNWhYY1luQjg/edit?usp=sharing BUG=NONE TEST=Start Chrome with --new-profile-management. Click on the avatar button. The bubble's right edge should be perfectly aligned to the button's edge. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284603

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M chrome/browser/ui/cocoa/profiles/avatar_base_controller.mm View 2 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
noms (inactive)
6 years, 5 months ago (2014-07-21 19:41:56 UTC) #1
Alexei Svitkine (slow)
lgtm
6 years, 5 months ago (2014-07-21 19:43:18 UTC) #2
noms (inactive)
The CQ bit was checked by noms@chromium.org
6 years, 5 months ago (2014-07-21 19:47:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noms@chromium.org/404443008/1
6 years, 5 months ago (2014-07-21 19:48:35 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 5 months ago (2014-07-21 21:50:10 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-21 22:01:07 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered_tests/builds/173175)
6 years, 5 months ago (2014-07-21 22:01:08 UTC) #7
noms (inactive)
The CQ bit was checked by noms@chromium.org
6 years, 5 months ago (2014-07-22 00:35:45 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noms@chromium.org/404443008/1
6 years, 5 months ago (2014-07-22 00:40:03 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 5 months ago (2014-07-22 01:22:23 UTC) #10
commit-bot: I haz the power
6 years, 5 months ago (2014-07-22 02:43:14 UTC) #11
Message was sent while issue was closed.
Change committed as 284603

Powered by Google App Engine
This is Rietveld 408576698