Listen for key events in SetupXI2ForXWindow()

Listen for key events in SetupXI2ForXWindow()

BUG=368750
R=sadrul
TEST=on device and desktop

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287772

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288142

[sadrul, 2014-07-22 16:00:49]

lgtm

[kpschoedel, 2014-07-22 16:02:37]

The CQ bit was checked by kpschoedel@chromium.org

[commit-bot: I haz the power, 2014-07-22 16:04:59]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/kpschoedel@chromium.org/404423002/1

[commit-bot: I haz the power, 2014-07-22 19:32:45]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)
  linux_chromium_rel_swarming on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel_sw...)

[commit-bot: I haz the power, 2014-07-22 20:17:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-22 20:17:53]

Try jobs failed on following builders:
  linux_chromium_rel_swarming on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel_sw...)

[kpschoedel, 2014-07-22 21:20:07]

The CQ bit was checked by kpschoedel@chromium.org

[commit-bot: I haz the power, 2014-07-22 21:21:31]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/kpschoedel@chromium.org/404423002/1

[commit-bot: I haz the power, 2014-07-22 22:40:50]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_chromium_rel_swarming on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel_sw...)

[commit-bot: I haz the power, 2014-07-22 23:19:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-22 23:19:36]

Try jobs failed on following builders:
  linux_chromium_rel_swarming on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel_sw...)

[kpschoedel, 2014-07-23 13:36:31]

The CQ bit was checked by kpschoedel@chromium.org

[commit-bot: I haz the power, 2014-07-23 13:37:09]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/kpschoedel@chromium.org/404423002/1

[commit-bot: I haz the power, 2014-07-23 14:23:52]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_chromium_rel_swarming on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel_sw...)

[kpschoedel, 2014-07-23 14:42:03]

The CQ bit was unchecked by kpschoedel@chromium.org

[kpschoedel, 2014-07-23 19:21:42]

The CQ bit was checked by kpschoedel@chromium.org

[commit-bot: I haz the power, 2014-07-23 19:23:51]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/kpschoedel@chromium.org/404423002/20001

[commit-bot: I haz the power, 2014-07-23 22:45:39]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_chromium_rel_swarming on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel_sw...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[commit-bot: I haz the power, 2014-07-23 23:32:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-23 23:32:45]

Try jobs failed on following builders:
  linux_chromium_rel_swarming on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel_sw...)

[kpschoedel, 2014-07-27 00:48:05]

The CQ bit was checked by kpschoedel@chromium.org

[commit-bot: I haz the power, 2014-07-27 00:48:33]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/kpschoedel@chromium.org/404423002/20001

[commit-bot: I haz the power, 2014-07-27 01:53:33]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_chromium_clang_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[commit-bot: I haz the power, 2014-07-27 02:30:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-27 02:30:24]

Try jobs failed on following builders:
  linux_chromium_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[flackr, 2014-07-28 13:26:31]

This seems to be a legitimate failure:
https://code.google.com/p/chromium/codesearch#chromium/src/ui/views/widget/de...
desktop_window_tree_host_x11.cc does not expect a GenericEvent with keypress
types by the looks of it.

[kpschoedel, 2014-07-30 15:06:16]

+erg, PTAL @ chrome/browser/ui/libgtk2ui/x11_input_method_context_impl_gtk2.cc

[Elliot Glaysher, 2014-07-30 21:27:07]

owners stamp lgtm

[kpschoedel, 2014-07-31 15:09:33]

The CQ bit was checked by kpschoedel@chromium.org

[commit-bot: I haz the power, 2014-07-31 15:11:01]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/kpschoedel@chromium.org/404423002/170001

[commit-bot: I haz the power, 2014-07-31 16:48:49]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_chromium_chromeos_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  win_chromium_compile_dbg on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[commit-bot: I haz the power, 2014-07-31 19:40:50]

Change committed as 286866

[erikchen, 2014-07-31 20:46:10]

A revert of this CL has been created in
https://codereview.chromium.org/438723003/ by erikchen@chromium.org.

The reason for reverting is: linux asan error:

http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Te....

[kpschoedel, 2014-08-05 15:28:37]

The CQ bit was checked by kpschoedel@chromium.org

[commit-bot: I haz the power, 2014-08-05 15:30:05]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/kpschoedel@chromium.org/404423002/230001

[commit-bot: I haz the power, 2014-08-05 18:10:55]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/42640)

[commit-bot: I haz the power, 2014-08-05 18:22:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-05 18:22:18]

Try jobs failed on following builders:
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/42672)

[kpschoedel, 2014-08-06 14:38:16]

The CQ bit was checked by kpschoedel@chromium.org

[commit-bot: I haz the power, 2014-08-06 14:38:55]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/kpschoedel@chromium.org/404423002/230001

[commit-bot: I haz the power, 2014-08-06 14:58:04]

Change committed as 287772

[lushnikov, 2014-08-07 11:51:00]

A revert of this CL has been created in
https://codereview.chromium.org/445413002/ by lushnikov@chromium.org.

The reason for reverting is: The patch regressed editing behavior:
crbug.com/401450.

[sadrul, 2014-08-07 13:24:02]

On 2014/08/07 11:51:00, lushnikov wrote:
> A revert of this CL has been created in
> https://codereview.chromium.org/445413002/ by mailto:lushnikov@chromium.org.
> 
> The reason for reverting is: The patch regressed editing behavior:
> crbug.com/401450.

Maybe we can start with doing this just on Chrome OS (we used to have similar
issues on linux desktop for XI2 mouse events too when we first started
processing XI2 events)

[kpschoedel, 2014-08-07 13:54:29]

On 2014/08/07 13:24:02, sadrul wrote:
> Maybe we can start with doing this just on Chrome OS (we used to have similar
> issues on linux desktop for XI2 mouse events too when we first started
> processing XI2 events)

Will do.

[kpschoedel, 2014-08-07 19:07:31]

The CQ bit was checked by kpschoedel@chromium.org

[commit-bot: I haz the power, 2014-08-07 19:11:53]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/kpschoedel@chromium.org/404423002/250001

[commit-bot: I haz the power, 2014-08-07 21:32:53]

Change committed as 288142