[Telemetry] Fix profile generation on Mac bots

[Telemetry] Fix profile generation on Mac bots

On Mac the profile directory may contain a socket "App Shim Socket", which we don't want to copy to the generated profile.
The original fix for this no longer works on the bots for an unknown reason, attempt an alternate fix.

BUG=396106
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284965

[tonyg, 2014-07-22 15:01:07]

Style nit and I think this would benefit significantly from a unittest. WDYT?

https://codereview.chromium.org/404413002/diff/1/tools/telemetry/telemetry/pa...
File tools/telemetry/telemetry/page/profile_generator.py (right):

https://codereview.chromium.org/404413002/diff/1/tools/telemetry/telemetry/pa...
tools/telemetry/telemetry/page/profile_generator.py:83: ignore_list.append(path)
Fix looks right, but I think we could structure this more readably as such:

if os.path.isdir(full_path):
  continue
if not IsSocket(full_path):  # Note factor this method out
  continue
if os.path.isfile(full_path):
  continue
logging.warning('Ignoring ...')
ignore_list.append(path)

https://codereview.chromium.org/404413002/diff/1/tools/telemetry/telemetry/pa...
tools/telemetry/telemetry/page/profile_generator.py:135: " <--output-dir>")
Does this fit on the previous line?

[Dominik Grewe, 2014-07-23 10:59:30]

On 2014/07/23 10:47:20, jeremy wrote:

lgtm. If this fixes the bots, can you add a unit test as a follow-up as tonyg
suggested?

[jeremy, 2014-07-23 11:47:01]

On 2014/07/23 10:59:30, Dominik Grewe wrote:
> On 2014/07/23 10:47:20, jeremy wrote:
> 
> lgtm. If this fixes the bots, can you add a unit test as a follow-up as tonyg
> suggested?

Ugh! I actually wrote a unit test but didn't add it to the CL, just noticed now
:(

I'm going to commit this to fix the bots, will upload the unit test in a
separate CL.

[jeremy, 2014-07-23 11:47:04]

The CQ bit was checked by jeremy@chromium.org

[commit-bot: I haz the power, 2014-07-23 11:48:28]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jeremy@chromium.org/404413002/20001

[commit-bot: I haz the power, 2014-07-23 17:03:00]

Change committed as 284965