Domain Reliability: Add wildcard domain support.

Domain Reliability: Add wildcard domain support.

Add support for configs with domains *.foo.bar.  Given a domain foo.bar, it
will first look for a config with domain foo.bar, then *.foo.bar, then *.bar.

BUG=396139
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288428

[Deprecated (see juliatuttle), 2014-07-22 18:01:57]

PTAL, davidben and rsleevi.

N.B.: The domain whitelist still applies, so we can only actually bake in
configs that use subdomains of domains we've approved.

[Ryan Sleevi, 2014-07-22 18:56:52]

I dislike wildcards for domains for a lot of reasons, some reasonable, some
unreasonable.

Mostly, they work really poorly for scoping authority.

If you're going to go down this route, then I think I'm going to ask to punt to
something a bit more fleshed out, perhaps on the bug, so that we can capture and
discuss the concerns and how they're addressed (I feel the CL will be a poor
substitute for that conversation)

https://codereview.chromium.org/404363003/diff/1/components/domain_reliabilit...
File components/domain_reliability/monitor.cc (right):

https://codereview.chromium.org/404363003/diff/1/components/domain_reliabilit...
components/domain_reliability/monitor.cc:259: // TODO(ttuttle): Make sure parent
is not in PSL before using.
This is big/important, but also, I think, requires better definition.

Should Google be able to report for *.appspot.com? appspot.com is in the PSL.

Or what about Amazon AWS?

[Ryan Sleevi, 2014-07-24 22:55:51]

In re-reading my response, I suspect the next steps may not have been clear:

Write up a design for how it's supposed to behave, then we'll talk on that, then
we'll comment on the implementation to make sure that "supposed to" matches how
it "should".

My concern here is that wildcards are full of trickiness. For example, LDAP lets
a*.foo.com. So, too, does HTTPS for that matter.

We could imagine a desire for domain.*.foo.com, which isn't valid for those
specs.

Then we'll also discuss the security implications for domains on the PSL and
what this would mean, as to whether or not the PSL is a suitable level for this.

[Deprecated (see juliatuttle), 2014-07-31 14:34:13]

Would it be okay if we landed this version for the Google-only version, and then
improved it as part of improving origin handling in general for the web-platform
launch?

[davidben, 2014-08-01 19:10:05]

This lgtm if Ryan's fine with landing this for the Google-only version. The PSL
thing will want to get sorted out before letting random sites register these.

https://codereview.chromium.org/404363003/diff/1/components/domain_reliabilit...
File components/domain_reliability/test_util.cc (right):

https://codereview.chromium.org/404363003/diff/1/components/domain_reliabilit...
components/domain_reliability/test_util.cc:168: new
std::string("http://*/always_report"));
Maybe rewrite this check to use, say, *.example.test or something like that.
Then this test wouldn't break in the future when the PSL logic is added.

[Deprecated (see juliatuttle), 2014-08-01 20:41:01]

The CQ bit was checked by ttuttle@chromium.org

[commit-bot: I haz the power, 2014-08-01 20:43:28]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/ttuttle@chromium.org/404363003/1

[commit-bot: I haz the power, 2014-08-02 00:43:50]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  mac_gpu_retina_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu_retina_tr...)
  android_aosp on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/bu...)
  android_chromium_gn_compile_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  android_clang_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)
  android_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg/bui...)
  android_dbg_triggered_tests on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios_dbg_simulator on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device/bu...)
  ios_rel_device_ninja on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel/...)
  win8_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...)
  win_chromium_compile_dbg on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
  win_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel/...)
  win_chromium_x64_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[commit-bot: I haz the power, 2014-08-02 00:45:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-02 00:45:38]

Try jobs failed on following builders:
  mac_gpu_retina_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu_retina_tr...)
  ios_dbg_simulator on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device/bu...)
  ios_rel_device_ninja on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)

[Deprecated (see juliatuttle), 2014-08-06 20:11:25]

The CQ bit was checked by ttuttle@chromium.org

[commit-bot: I haz the power, 2014-08-06 20:12:24]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/ttuttle@chromium.org/404363003/60001

[Deprecated (see juliatuttle), 2014-08-07 18:43:17]

The CQ bit was checked by ttuttle@chromium.org

[commit-bot: I haz the power, 2014-08-07 18:46:25]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/ttuttle@chromium.org/404363003/80001

[commit-bot: I haz the power, 2014-08-08 07:21:47]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_rel_swarming on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  win_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel/...)
  win_chromium_x64_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[commit-bot: I haz the power, 2014-08-08 07:52:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-08 07:52:34]

Try jobs failed on following builders:
  linux_chromium_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Deprecated (see juliatuttle), 2014-08-08 19:47:04]

The CQ bit was checked by ttuttle@chromium.org

[commit-bot: I haz the power, 2014-08-08 19:48:40]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/ttuttle@chromium.org/404363003/100001

[commit-bot: I haz the power, 2014-08-08 20:58:29]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  ios_rel_device on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device/bu...)

[commit-bot: I haz the power, 2014-08-08 21:05:46]

Change committed as 288428