Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 404353004: [Android] Only build relocation_packer_unittests on ARM and ARM64. (Closed)

Created:
6 years, 5 months ago by Bernhard Bauer
Modified:
6 years, 5 months ago
CC:
chromium-reviews, Anton
Project:
chromium
Visibility:
Public.

Description

[Android] Only build relocation_packer_unittests on ARM and ARM64. This fixes building "all" on non-ARM platforms. TBR=ben@chromium.org NOTRY=true BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284669

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M build/all.gyp View 1 chunk +8 lines, -1 line 0 comments Download

Messages

Total messages: 13 (0 generated)
Bernhard Bauer
Please review.
6 years, 5 months ago (2014-07-22 12:12:33 UTC) #1
simonb1
Lgtm, thanks. Duplicates: https://codereview.chromium.org/408113003/ +cc anton
6 years, 5 months ago (2014-07-22 12:20:39 UTC) #2
Bernhard Bauer
The CQ bit was checked by bauerb@chromium.org
6 years, 5 months ago (2014-07-22 12:30:49 UTC) #3
Bernhard Bauer
On 2014/07/22 12:20:39, simonb1 wrote: > Lgtm, thanks. Duplicates: > > https://codereview.chromium.org/408113003/ > > +cc ...
6 years, 5 months ago (2014-07-22 12:31:10 UTC) #4
Anton
Well, I hear you are a committer, so you win. On Tue, Jul 22, 2014 ...
6 years, 5 months ago (2014-07-22 12:31:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bauerb@chromium.org/404353004/1
6 years, 5 months ago (2014-07-22 12:32:02 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-22 12:32:03 UTC) #7
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 5 months ago (2014-07-22 12:32:03 UTC) #8
Bernhard Bauer
Ben: TBR (gyp file change to fix build)
6 years, 5 months ago (2014-07-22 12:33:48 UTC) #9
Bernhard Bauer
The CQ bit was checked by bauerb@chromium.org
6 years, 5 months ago (2014-07-22 12:33:51 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bauerb@chromium.org/404353004/1
6 years, 5 months ago (2014-07-22 12:35:09 UTC) #11
commit-bot: I haz the power
Change committed as 284669
6 years, 5 months ago (2014-07-22 12:36:16 UTC) #12
Ben Goodger (Google)
6 years, 5 months ago (2014-07-23 16:05:52 UTC) #13
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698