content/browser/push_messaging_message_filter.cc - Issue 404353003: Define PushMessagingApplicationId and replace ad-hoc code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/push_messaging_message_filter.cc

Issue 404353003: Define PushMessagingApplicationId and replace ad-hoc code. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address comments from jam and fgorski. Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/push_messaging_message_filter.cc

diff --git a/content/browser/push_messaging_message_filter.cc b/content/browser/push_messaging_message_filter.cc

index f34ffb2ad1fee39745d817a691f06ec54846c72f..01193c14a34d554fc5024f06ff7a5475a4bcedc0 100644

--- a/content/browser/push_messaging_message_filter.cc

+++ b/content/browser/push_messaging_message_filter.cc

@@ -84,10 +84,8 @@ void PushMessagingMessageFilter::DoRegister(

PUSH_MESSAGING_STATUS_REGISTRATION_FAILED_SERVICE_NOT_AVAILABLE));

return;

}

- // TODO(mvanouwerkerk): Is this the app_id format we want to use?

- std::string app_id =

- origin.spec() + " " + base::Int64ToString(service_worker_registration_id);

- service()->Register(app_id,

+ service()->Register(origin,

+ service_worker_registration_id,

sender_id,

render_process_id_,

render_frame_id,

« no previous file with comments | « chrome/chrome_tests_unit.gypi ('k') | content/content_browser.gypi » ('j') | no next file with comments »