Issue 404343003: Add bandwidth_estimate and server_namespace fields to the source-address

Issue 404343003: Add bandwidth_estimate and server_namespace fields to the source-address (Closed)

Created:
6 years, 5 months ago by ramant (doing other things)

Modified:
6 years, 5 months ago

Reviewers:
wtc, Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org, Robbie Shade, avd, wtc

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Add bandwidth_estimate and server_namespace fields to the source-address token proto. Not used anywhere, this CL is really just for discussion about which fields (and fieldnames) we should use. Merge internal change: 71360060 R=rch@chromium.org

Patch Set 1 #

Total comments: 8

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+93 lines, -5 lines)			Patch
	M	net/quic/crypto/source_address_token.h	View		2 chunks	+82 lines, -5 lines	8 comments	Download
	M	net/quic/crypto/source_address_token.cc	View		3 chunks	+11 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

wtc

Patch set 1 LGTM. https://codereview.chromium.org/404343003/diff/1/net/quic/crypto/source_address_token.h File net/quic/crypto/source_address_token.h (right): https://codereview.chromium.org/404343003/diff/1/net/quic/crypto/source_address_token.h#newcode60 net/quic/crypto/source_address_token.h:60: // serving_region is used to ...

6 years, 5 months ago (2014-07-23 23:17:14 UTC) #3

ramant (doing other things)

6 years, 5 months ago (2014-07-23 23:56:00 UTC) #4

Fixed in https://codereview.chromium.org/411823002/

thanks Wan-Teh for the comments
raman

https://codereview.chromium.org/404343003/diff/1/net/quic/crypto/source_addre...
File net/quic/crypto/source_address_token.h (right):

https://codereview.chromium.org/404343003/diff/1/net/quic/crypto/source_addre...
net/quic/crypto/source_address_token.h:60: // serving_region is used to decide
whether or not the bandwidth estimate and
On 2014/07/23 23:17:14, wtc wrote:
> 
> serving_region => serving_region_

Done.

https://codereview.chromium.org/404343003/diff/1/net/quic/crypto/source_addre...
net/quic/crypto/source_address_token.h:63: // serving_region string if they are
expected to have similar network
On 2014/07/23 23:17:14, wtc wrote:
> 
> serving_region => serving_region_

Done.

https://codereview.chromium.org/404343003/diff/1/net/quic/crypto/source_addre...
net/quic/crypto/source_address_token.h:111: // ip contains either 4 (IPv4) or 16
(IPv6) bytes of IP address in network
On 2014/07/23 23:17:14, wtc wrote:
> 
> ip => ip_

Done.

https://codereview.chromium.org/404343003/diff/1/net/quic/crypto/source_addre...
net/quic/crypto/source_address_token.h:114: // timestamp contains a UNIX
timestamp value of the time when the token was
On 2014/07/23 23:17:14, wtc wrote:
> 
> timestamp => timestamp_ (just the first occurrence)

Done.

Expand Messages | Collapse Messages