Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 404343002: Introduce DEFINE_CONTENT_DATA_TYPE_CASTS, and use it (Closed)

Created:
6 years, 5 months ago by gyuyoung-inactive
Modified:
6 years, 5 months ago
Reviewers:
tkent
CC:
blink-reviews, blink-reviews-rendering, zoltan1, blink-reviews-css, eae+blinkwatch, ed+blinkwatch_opera.com, leviw+renderwatch, dglazkov+blink, apavlov+blink_chromium.org, jchaffraix+rendering, darktears, pdr., rune+blink, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Introduce DEFINE_CONTENT_DATA_TYPE_CASTS, and use it As a step to use toFoo, this cl introduces DEFINE_CONTENT_DATA_TYPE_CASTS, which generates toImage|Text|Counter|QuoteElementData(). Those functions will detect bad type cast. BUG=309516 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178703

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -12 lines) Patch
M Source/core/css/CSSComputedStyleDeclaration.cpp View 1 chunk +5 lines, -4 lines 0 comments Download
M Source/core/css/resolver/StyleResourceLoader.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderBlock.cpp View 1 chunk +2 lines, -4 lines 0 comments Download
M Source/core/rendering/RenderObject.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/style/ContentData.h View 5 chunks +11 lines, -0 lines 0 comments Download
M Source/core/rendering/style/RenderStyle.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 19 (0 generated)
gyuyoung-inactive
PTAL
6 years, 5 months ago (2014-07-22 03:47:02 UTC) #1
tkent
lgtm
6 years, 5 months ago (2014-07-22 05:15:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/404343002/1
6 years, 5 months ago (2014-07-22 05:15:56 UTC) #3
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 5 months ago (2014-07-22 06:18:47 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-22 07:23:47 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/18123)
6 years, 5 months ago (2014-07-22 07:23:48 UTC) #6
gyuyoung-inactive
The CQ bit was checked by gyuyoung.kim@samsung.com
6 years, 5 months ago (2014-07-22 07:46:28 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/404343002/1
6 years, 5 months ago (2014-07-22 07:47:39 UTC) #8
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 5 months ago (2014-07-22 08:50:49 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-22 09:32:23 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/18178)
6 years, 5 months ago (2014-07-22 09:32:25 UTC) #11
gyuyoung-inactive
The CQ bit was checked by gyuyoung.kim@samsung.com
6 years, 5 months ago (2014-07-22 10:32:02 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/404343002/1
6 years, 5 months ago (2014-07-22 10:32:53 UTC) #13
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 5 months ago (2014-07-22 11:21:34 UTC) #14
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-22 11:52:09 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/18239)
6 years, 5 months ago (2014-07-22 11:52:10 UTC) #16
gyuyoung-inactive
The CQ bit was checked by gyuyoung.kim@samsung.com
6 years, 5 months ago (2014-07-22 22:01:58 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/404343002/1
6 years, 5 months ago (2014-07-22 22:02:59 UTC) #18
commit-bot: I haz the power
6 years, 5 months ago (2014-07-22 22:36:01 UTC) #19
Message was sent while issue was closed. 
Change committed as 178703

Powered by Google App Engine
This is Rietveld 408576698