Issue 404333003: Avoid redundent redefinition of __STDC_FORMAT_MACROS when building with clang

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 404333003: Avoid redundent redefinition of __STDC_FORMAT_MACROS when building with clang (Closed)

Created:
6 years, 5 months ago by rmcilroy

Modified:
6 years, 5 months ago

Reviewers:
dusmil.imgtec, jochen (gone - plz use gerrit), paul.l...

CC:
benm (inactive), v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

Avoid redundent redefinition of __STDC_FORMAT_MACROS when building with clang R=jochen@chromium.org, paul.lind@imgtec.com Committed: https://code.google.com/p/v8/source/detail?r=22554

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	M	src/arm64/constants-arm64.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
	M	src/mips64/constants-mips64.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Total messages: 4 (0 generated)

rmcilroy

This change is to avoid the following warning in a WebView build using clang: external/chromium_org/v8/src/arm64/constants-arm64.h:18:9: ...

6 years, 5 months ago (2014-07-22 09:53:09 UTC) #1

rmcilroy

6 years, 5 months ago (2014-07-23 11:24:36 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r22554 (presubmit successful).