Source/bindings/v8/custom/V8TypedArrayCustom.h - Issue 40433002: Make wrapperTypeInfo static member const in bindings classes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/custom/V8TypedArrayCustom.h

Issue 40433002: Make wrapperTypeInfo static member const in bindings classes (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rebase Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/bindings/v8/custom/V8HTMLImageElementConstructor.cpp ('k') | Source/build/scripts/templates/ElementWrapperFactory.cpp.tmpl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/v8/custom/V8TypedArrayCustom.h

diff --git a/Source/bindings/v8/custom/V8TypedArrayCustom.h b/Source/bindings/v8/custom/V8TypedArrayCustom.h

index c4013e6418797aa5faec901a276ea5567241dd63..dbf268bd75f6335fda1eaeed30f7570d98f2e48f 100644

--- a/Source/bindings/v8/custom/V8TypedArrayCustom.h

+++ b/Source/bindings/v8/custom/V8TypedArrayCustom.h

@@ -59,7 +59,7 @@ public:

static TypedArray* toNative(v8::Handle<v8::Object>);

static void derefObject(void*);

- static WrapperTypeInfo wrapperTypeInfo;

+ static const WrapperTypeInfo wrapperTypeInfo;

static const int internalFieldCount = v8DefaultWrapperInternalFieldCount;

static v8::Handle<v8::Object> wrap(TypedArray* impl, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate)

@@ -134,7 +134,7 @@ private:

template<typename TypedArray>

class TypedArrayWrapperTraits {

public:

- static WrapperTypeInfo* info() { return &V8TypedArray<TypedArray>::wrapperTypeInfo; }

+ static const WrapperTypeInfo* info() { return &V8TypedArray<TypedArray>::wrapperTypeInfo; }

};

@@ -176,7 +176,7 @@ TypedArray* V8TypedArray<TypedArray>::toNative(v8::Handle<v8::Object> object)

template <typename TypedArray>

-WrapperTypeInfo V8TypedArray<TypedArray>::wrapperTypeInfo = {

+const WrapperTypeInfo V8TypedArray<TypedArray>::wrapperTypeInfo = {

0, V8TypedArray<TypedArray>::derefObject,

0, 0, 0, 0, 0, WrapperTypeObjectPrototype

};