Issue 404273002: [webcrypto] Implement Sign() and Verify() for RSA-SSA using OpenSSL.

Issue 404273002: [webcrypto] Implement Sign() and Verify() for RSA-SSA using OpenSSL. (Closed)

Created:
6 years, 5 months ago by eroman

Modified:
6 years, 5 months ago

Reviewers:
Ryan Sleevi

CC:
chromium-reviews, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

[webcrypto] Implement Sign() and Verify() for RSA-SSA using OpenSSL. BUG=389319 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284655

Patch Set 2 : Address sleevi comment #

Patch Set 3 : Rebase onto master #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+91 lines, -3 lines)			Patch
	M	content/child/webcrypto/openssl/rsa_ssa_openssl.cc	View	1	2 chunks	+89 lines, -1 line	0 comments	Download
	M	content/child/webcrypto/shared_crypto_unittest.cc	View	2	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Ryan Sleevi

LGTM % nit. https://codereview.chromium.org/404273002/diff/1/content/child/webcrypto/openssl/rsa_ssa_openssl.cc File content/child/webcrypto/openssl/rsa_ssa_openssl.cc (right): https://codereview.chromium.org/404273002/diff/1/content/child/webcrypto/openssl/rsa_ssa_openssl.cc#newcode117 content/child/webcrypto/openssl/rsa_ssa_openssl.cc:117: return Status::OperationError(); Why not just *signature_match ...

6 years, 5 months ago (2014-07-22 02:07:21 UTC) #2

eroman

https://codereview.chromium.org/404273002/diff/1/content/child/webcrypto/openssl/rsa_ssa_openssl.cc File content/child/webcrypto/openssl/rsa_ssa_openssl.cc (right): https://codereview.chromium.org/404273002/diff/1/content/child/webcrypto/openssl/rsa_ssa_openssl.cc#newcode117 content/child/webcrypto/openssl/rsa_ssa_openssl.cc:117: return Status::OperationError(); On 2014/07/22 02:07:21, Ryan Sleevi wrote: > ...

6 years, 5 months ago (2014-07-22 04:57:09 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/404273002/40001

6 years, 5 months ago (2014-07-22 05:02:08 UTC) #5

Message was sent while issue was closed.

Change committed as 284655

Expand Messages | Collapse Messages