Source/web/tests/data/fixed_layout.html - Issue 40423003: Experimental viewport meta tag support for desktop, Blink-side.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/web/tests/data/fixed_layout.html

Issue 40423003: Experimental viewport meta tag support for desktop, Blink-side. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Android stylesheet and fixes Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
	1 <head>

	2 <style>

	3 /* Since tests are built with desktop viewport settings set the viewport
	aelias_OOO_until_Jul13 2013/10/31 21:06:59 Hmm, this doesn't feel like the right way to test Hmm, this doesn't feel like the right way to test this. Is there a way we could get the relevant unit tests to use the new Android UA stylesheet instead? bokan 2013/10/31 21:18:14 Hmm...I agree this feels wrong. The test this belo Show quoted text On 2013/10/31 21:06:59, aelias wrote: > Hmm, this doesn't feel like the right way to test this. Is there a way we could > get the relevant unit tests to use the new Android UA stylesheet instead? Hmm...I agree this feels wrong. The test this belongs to (WebFrameTest) has a mix of Android and Desktop tests though. Also, the UA stylesheet is included in the build so it will apply to all unit tests. It should be possible to replace the stylesheet in code, but we'd have to split out the Android specific tests into their own unit test for that to work cleanly (something I'm already planing on doing)
	4 to behave like Android */

	5 @viewport {

	6 min-width: 980px;

	7 }

	8 </style>

	9 </head>

1 <body>Ordinary non-mobile page</body>	10 <body>Ordinary non-mobile page</body>

OLD	NEW

« Source/web/WebSettingsImpl.h ('K') | « Source/web/tests/WebFrameTest.cpp ('k') | Source/web/tests/data/no_viewport_tag.html » ('j') | public/web/WebSettings.h » ('J')