Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Unified Diff: ash/frame/caption_buttons/frame_size_button.cc

Issue 404213003: [WIP] Allow scroll events to permanently change the default gesture handler in RootView (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: friend test Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/views/tabs/tab.h » ('j') | chrome/browser/ui/views/tabs/tab.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/frame/caption_buttons/frame_size_button.cc
diff --git a/ash/frame/caption_buttons/frame_size_button.cc b/ash/frame/caption_buttons/frame_size_button.cc
index 1399453ffdcfff07c8b357fc88001905a58fac16..56f70f65300de3b5cd23f7534da23262f77cfbbc 100644
--- a/ash/frame/caption_buttons/frame_size_button.cc
+++ b/ash/frame/caption_buttons/frame_size_button.cc
@@ -120,8 +120,7 @@ void FrameSizeButton::OnGestureEvent(ui::GestureEvent* event) {
if (event->type() == ui::ET_GESTURE_TAP ||
event->type() == ui::ET_GESTURE_SCROLL_END ||
- event->type() == ui::ET_SCROLL_FLING_START ||
- event->type() == ui::ET_GESTURE_END) {
tdresser 2014/07/24 18:17:22 This changes behavior, doesn't it? Are we ok with
sadrul 2014/07/24 19:12:13 Looks like the code starts doing things in respons
tdresser 2014/07/24 19:16:44 Shouldn't it also listen to LONG_TAP?
sadrul 2014/07/24 19:21:34 Good point. That will probably be necessary here,
tdanderson 2014/07/25 17:16:10 Thanks for pointing this out.
+ event->type() == ui::ET_SCROLL_FLING_START) {
if (CommitSnap(*event)) {
if (event->type() == ui::ET_GESTURE_TAP) {
TouchUMA::GetInstance()->RecordGestureAction(
« no previous file with comments | « no previous file | chrome/browser/ui/views/tabs/tab.h » ('j') | chrome/browser/ui/views/tabs/tab.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698