Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issue 404203002: Extension docs: Make comments in IDL files generate paragraphs rather than (Closed)

Created:
6 years, 5 months ago by not at google - send to devlin
Modified:
6 years, 5 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Extension docs: Make comments in IDL files generate paragraphs rather than double <br> elements, and adjust CSS to make it look good. Fix up a couple of IDL files to just use newlines rather than <br> elements. R=mangini@chromium.org, asargent@chromium.org NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284571

Patch Set 1 #

Total comments: 2

Patch Set 2 : rebase, bump yaml files #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -47 lines) Patch
M chrome/common/extensions/api/app_window.idl View 5 chunks +28 lines, -14 lines 0 comments Download
M chrome/common/extensions/api/identity.idl View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/common/extensions/docs/server2/app.yaml View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/server2/cron.yaml View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/static/css/out/site.css View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/static/sass/_api.scss View 1 1 chunk +15 lines, -9 lines 0 comments Download
M tools/json_schema_compiler/dart_test/comments.dart View 1 chunk +6 lines, -6 lines 0 comments Download
M tools/json_schema_compiler/dart_test/comments.idl View 1 chunk +1 line, -1 line 0 comments Download
M tools/json_schema_compiler/idl_schema.py View 2 chunks +12 lines, -10 lines 0 comments Download
M tools/json_schema_compiler/idl_schema_test.py View 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
not at google - send to devlin
6 years, 5 months ago (2014-07-21 19:21:22 UTC) #1
Renato Mangini (chromium)
On 2014/07/21 19:21:22, kalman wrote: lgtm
6 years, 5 months ago (2014-07-21 19:42:00 UTC) #2
asargent_no_longer_on_chrome
lgtm https://codereview.chromium.org/404203002/diff/1/chrome/common/extensions/docs/static/css/out/site.css File chrome/common/extensions/docs/static/css/out/site.css (right): https://codereview.chromium.org/404203002/diff/1/chrome/common/extensions/docs/static/css/out/site.css#newcode4 chrome/common/extensions/docs/static/css/out/site.css:4: */article,aside,details,figcaption,figure,footer,header,hgroup,main,nav,section,summary{display:block}audio,canvas,video{display:inline-block;*display:inline;*zoom:1}audio:not([controls]){display:none;height:0}[hidden],template{display:none}html{font-family:sans-serif;font-size:100%;-ms-text-size-adjust:100%;-webkit-text-size-adjust:100%}button,input,select,textarea{font-family:sans-serif}body{margin:0}a{background:transparent}a:focus{outline:thin dotted}a:active,a:hover{outline:0}p,pre{margin:1.5em 0}blockquote{margin:1.5em 40px}h1{font-size:2em;line-height:1.5em;margin-top:0.75em;margin-bottom:0.75em}h2{font-size:1.5em;line-height:2em;margin-top:1em;margin-bottom:1em}h3{font-size:1.17em;line-height:1.28205em;margin-top:1.28205em;margin-bottom:1.28205em}h4{font-size:1em;line-height:1.5em;margin-top:1.5em;margin-bottom:1.5em}h5{font-size:0.83em;line-height:1.80723em;margin-top:1.80723em;margin-bottom:1.80723em}h6{font-size:0.67em;line-height:2.23881em;margin-top:2.23881em;margin-bottom:2.23881em}abbr[title]{border-bottom:1px dotted}b,strong{font-weight:bold}dfn{font-style:italic}hr{-webkit-box-sizing:content-box;-moz-box-sizing:content-box;box-sizing:content-box;height:0}mark{background:#ff0;color:#000}code,kbd,pre,samp{font-family:monospace, serif;_font-family:'courier new', monospace;font-size:1em}pre{white-space:pre;white-space:pre-wrap;word-wrap:break-word}q{quotes:"\201C" ...
6 years, 5 months ago (2014-07-21 23:48:35 UTC) #3
not at google - send to devlin
https://codereview.chromium.org/404203002/diff/1/chrome/common/extensions/docs/static/css/out/site.css File chrome/common/extensions/docs/static/css/out/site.css (right): https://codereview.chromium.org/404203002/diff/1/chrome/common/extensions/docs/static/css/out/site.css#newcode4 chrome/common/extensions/docs/static/css/out/site.css:4: */article,aside,details,figcaption,figure,footer,header,hgroup,main,nav,section,summary{display:block}audio,canvas,video{display:inline-block;*display:inline;*zoom:1}audio:not([controls]){display:none;height:0}[hidden],template{display:none}html{font-family:sans-serif;font-size:100%;-ms-text-size-adjust:100%;-webkit-text-size-adjust:100%}button,input,select,textarea{font-family:sans-serif}body{margin:0}a{background:transparent}a:focus{outline:thin dotted}a:active,a:hover{outline:0}p,pre{margin:1.5em 0}blockquote{margin:1.5em 40px}h1{font-size:2em;line-height:1.5em;margin-top:0.75em;margin-bottom:0.75em}h2{font-size:1.5em;line-height:2em;margin-top:1em;margin-bottom:1em}h3{font-size:1.17em;line-height:1.28205em;margin-top:1.28205em;margin-bottom:1.28205em}h4{font-size:1em;line-height:1.5em;margin-top:1.5em;margin-bottom:1.5em}h5{font-size:0.83em;line-height:1.80723em;margin-top:1.80723em;margin-bottom:1.80723em}h6{font-size:0.67em;line-height:2.23881em;margin-top:2.23881em;margin-bottom:2.23881em}abbr[title]{border-bottom:1px dotted}b,strong{font-weight:bold}dfn{font-style:italic}hr{-webkit-box-sizing:content-box;-moz-box-sizing:content-box;box-sizing:content-box;height:0}mark{background:#ff0;color:#000}code,kbd,pre,samp{font-family:monospace, serif;_font-family:'courier new', monospace;font-size:1em}pre{white-space:pre;white-space:pre-wrap;word-wrap:break-word}q{quotes:"\201C" "\201D" ...
6 years, 5 months ago (2014-07-21 23:50:42 UTC) #4
not at google - send to devlin
The CQ bit was checked by kalman@chromium.org
6 years, 5 months ago (2014-07-21 23:59:45 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kalman@chromium.org/404203002/20001
6 years, 5 months ago (2014-07-22 00:01:13 UTC) #6
commit-bot: I haz the power
6 years, 5 months ago (2014-07-22 00:55:33 UTC) #7
Message was sent while issue was closed.
Change committed as 284571

Powered by Google App Engine
This is Rietveld 408576698