Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(468)

Issue 404173002: tools: more post-mortem constants (Closed)

Created:
6 years, 5 months ago by indutny
Modified:
6 years, 5 months ago
Reviewers:
danno
CC:
v8-dev
Base URL:
gh:v8/v8@master
Visibility:
Public.

Description

tools: more post-mortem constants Expose more info about post-mortem constants Useful for node.js and/or other tools. BUG= R=danno@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22549

Patch Set 1 #

Patch Set 2 : fix type #

Patch Set 3 : more constants #

Patch Set 4 : more constants #

Patch Set 5 : type field bitshifts #

Patch Set 6 : prototype offset #

Patch Set 7 : bit_field2 constant #

Patch Set 8 : elements kind #

Patch Set 9 : more constants #

Patch Set 10 : improve python tool #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -2 lines) Patch
M tools/gen-postmortem-metadata.py View 1 2 3 4 5 6 7 8 9 6 chunks +41 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
indutny
6 years, 5 months ago (2014-07-21 18:20:45 UTC) #1
danno
lgtm, I'll land this for you.
6 years, 5 months ago (2014-07-22 19:12:54 UTC) #2
indutny
On 2014/07/22 19:12:54, danno wrote: > lgtm, I'll land this for you. Thank you!
6 years, 5 months ago (2014-07-22 20:39:06 UTC) #3
danno
6 years, 5 months ago (2014-07-23 10:48:22 UTC) #4
Message was sent while issue was closed.
Committed patchset #10 manually as r22549 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698