Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Issue 404153002: Fix a compile error caused in some compiler. (Closed)

Created:
6 years, 5 months ago by Jun Mukai
Modified:
6 years, 5 months ago
Reviewers:
flackr, sadrul
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Fix a compile error caused in some compiler. This switch covers all state, however, some compiler may cause errors for no return statement after switch(). BUG=395633 R=flackr@chromium.org, sadrul@chromium.org TEST=compile Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284456

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M athena/home/home_card_impl.cc View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Jun Mukai
6 years, 5 months ago (2014-07-21 17:39:26 UTC) #1
flackr
lgtm
6 years, 5 months ago (2014-07-21 17:42:43 UTC) #2
Jun Mukai
6 years, 5 months ago (2014-07-21 17:48:23 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r284456 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698