Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Issue 404113003: Use 0 instead of undefined for uninitialized stub key. (Closed)

Created:
6 years, 5 months ago by Yang
Modified:
6 years, 5 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Use 0 instead of undefined for uninitialized stub key. The CPU profiler looks at uninitialized code objects, which triggers an assertion. TBR=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22507

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/objects-debug.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Yang
6 years, 5 months ago (2014-07-21 13:51:31 UTC) #1
Yang
Committed patchset #1 manually as r22507 (presubmit successful).
6 years, 5 months ago (2014-07-21 13:51:48 UTC) #2
Jakob Kummerow
6 years, 5 months ago (2014-07-21 15:12:37 UTC) #3
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698