Issue 404093002: Fix automatic version update.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 404093002: Fix automatic version update. (Closed)

Created:
6 years, 5 months ago by Michael Achenbach

Modified:
6 years, 5 months ago

Reviewers:
Jarin

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

Fix automatic version update. This fixes two things: 1. Guarantee that versions are bumped up also when presubmit errors exists. Those errors originate from other CLs and should not stop the automatic versioning. 2. Calculate the last bleeding edge version when pushing to trunk based on remote branch svn/bleeding_edge and not on local branch master. The master branch is not kept up-to-date by the script. BUG= TBR=jarin@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22501

Patch Set 1 #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+11 lines, -6 lines)			Patch
M	tools/push-to-trunk/bump_up_version.py	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	tools/push-to-trunk/git_recipes.py	View	2 chunks	+4 lines, -1 line	0 comments	Download
M	tools/push-to-trunk/push_to_trunk.py	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/push-to-trunk/test_scripts.py	View	2 chunks	+4 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Michael Achenbach

6 years, 5 months ago (2014-07-21 12:13:44 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r22501 (tree was closed).

Expand Messages | Collapse Messages