Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1225)

Unified Diff: src/store-buffer.cc

Issue 404083002: Wait for sweeper threads when a scan on scavenge page is not swept. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/mark-compact.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/store-buffer.cc
diff --git a/src/store-buffer.cc b/src/store-buffer.cc
index 3745d91a8a417071b8f40262069ebee34deed332..d1a04d292fb2cb0f79282972caa0b26c8d3b8c2f 100644
--- a/src/store-buffer.cc
+++ b/src/store-buffer.cc
@@ -505,6 +505,16 @@ void StoreBuffer::IteratePointersToNewSpace(ObjectSlotCallback slot_callback,
}
}
} else {
+ if (page->parallel_sweeping() > MemoryChunk::SWEEPING_FINALIZE) {
+ heap_->mark_compact_collector()->SweepInParallel(page, owner);
+ if (page->parallel_sweeping() > MemoryChunk::SWEEPING_FINALIZE) {
+ // We were not able to sweep that page, i.e., a concurrent
+ // sweeper thread currently owns this page.
+ // TODO(hpayer): This may introduce a huge pause here. We
+ // just care about finish sweeping of the scan on scavenge page.
+ heap_->mark_compact_collector()->EnsureSweepingCompleted();
+ }
+ }
FindPointersToNewSpaceInRegion(
start, end, slot_callback, clear_maps);
}
« no previous file with comments | « src/mark-compact.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698