Issue 404039: Sort the origins in the cookies_tree_model by effective TLD, as opposed...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 404039: Sort the origins in the cookies_tree_model by effective TLD, as opposed... (Closed)

Created:
11 years, 1 month ago by ian fette

Modified:
9 years, 6 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews_googlegroups.com, Paweł Hajdan Jr., ben+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Sort the origins in the cookies_tree_model by effective TLD, as opposed to a lexicographical sort on the entire origin as a string. BUG=28192 TEST=cookies_tree_model_unittest.cc Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=32522

Patch Set 1 #

Total comments: 4

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+87 lines, -8 lines)			Patch
	M	chrome/browser/cookies_tree_model.cc	View	1 2 3 4	2 chunks	+49 lines, -1 line	0 comments	Download
	M	chrome/browser/cookies_tree_model_unittest.cc	View	1 2	7 chunks	+38 lines, -7 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Ben Goodger (Google)

LGTM http://codereview.chromium.org/404039/diff/1/2 File chrome/browser/cookies_tree_model.cc (right): http://codereview.chromium.org/404039/diff/1/2#newcode92 Line 92: // ".google.com" the same as "google.com". maybe ...

11 years, 1 month ago (2009-11-19 02:13:33 UTC) #2

ian fette

11 years, 1 month ago (2009-11-19 03:40:31 UTC) #3

Thanks Ben. Not sure what is up with the mac+linux trybots, looks like flake,
but will try again and submit once they're green.

http://codereview.chromium.org/404039/diff/1/2
File chrome/browser/cookies_tree_model.cc (right):

http://codereview.chromium.org/404039/diff/1/2#newcode92
Line 92: // ".google.com" the same as "google.com".
On 2009/11/19 02:13:33, Ben Goodger wrote:
> maybe add some test values for this in your unittest too...

Done.

http://codereview.chromium.org/404039/diff/1/3
File chrome/browser/cookies_tree_model_unittest.cc (right):

http://codereview.chromium.org/404039/diff/1/3#newcode310
Line 310: DeleteCookie(cookies_model.GetRoot()->GetChild(1));  // Delete "D"
On 2009/11/19 02:13:33, Ben Goodger wrote:
> nit: remove 2 extra spaces of indent.

Done.

Expand Messages | Collapse Messages