Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 404016: Replace hard-coded media_format() methods with Google Mock methods declared in mock_filters.h. (Closed)

Created:
11 years, 1 month ago by scherkus (not reviewing)
Modified:
9 years, 7 months ago
Reviewers:
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Replace hard-coded media_format() methods with Google Mock methods declared in mock_filters.h. Updated unit tests accordingly. Patch by Dominic Jodoin <dominic.jodoin@gmail.com>; BUG=21040 TEST=Run the media_unittests and AudioRendererImplTest test suite in unit_tests. Ensure there is no Google Mock failures and that all tests are passing. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=32267

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -52 lines) Patch
M AUTHORS View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/renderer/media/audio_renderer_impl_unittest.cc View 4 chunks +16 lines, -3 lines 0 comments Download
M media/base/mock_filters.h View 7 chunks +4 lines, -32 lines 0 comments Download
M media/base/pipeline_impl_unittest.cc View 17 chunks +50 lines, -14 lines 0 comments Download
M media/filters/audio_renderer_base_unittest.cc View 3 chunks +12 lines, -1 line 0 comments Download
M media/filters/video_renderer_base_unittest.cc View 4 chunks +14 lines, -2 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698