Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1912)

Unified Diff: Tools/GardeningServer/ui/ct-results-comparison.html

Issue 403983002: Port pixelzoomer.js/css to ct-results-comparison. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: make component. add tests. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Tools/GardeningServer/run-unittests.html ('k') | Tools/GardeningServer/ui/ct-results-comparison-tests.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Tools/GardeningServer/ui/ct-results-comparison.html
diff --git a/Tools/GardeningServer/ui/ct-results-comparison.html b/Tools/GardeningServer/ui/ct-results-comparison.html
index 4106247c3b6a7422dfecd46465f8f9a5cbaffd2c..60431e005b685f962d41d01e2f8b65489cb2582a 100644
--- a/Tools/GardeningServer/ui/ct-results-comparison.html
+++ b/Tools/GardeningServer/ui/ct-results-comparison.html
@@ -4,33 +4,78 @@ Use of this source code is governed by a BSD-style license that can be
found in the LICENSE file.
-->
+<link rel="import" href="ct-results-comparison-zoomer.html">
<link rel="import" href="ct-test-output.html">
-<polymer-element name="ct-results-comparison" attributes="type expectedUrl actualUrl diffUrl" noscript>
- <template>
- <style>
- :host {
- display: flex;
- flex-wrap: wrap;
- width: 100%;
- }
- .container {
- flex: 1;
- min-width: 300px;
- }
- </style>
-
- <div class="container">
- <h2>Expected</h2>
- <ct-test-output type="{{type}}" url="{{expectedUrl}}"></ct-test-output>
- </div>
- <div class="container">
- <h2>Actual</h2>
- <ct-test-output type="{{type}}" url="{{actualUrl}}"></ct-test-output>
- </div>
- <div class="container">
- <h2>Diff</h2>
- <ct-test-output type="{{type}}" url="{{diffUrl}}"></ct-test-output>
- </div>
+<polymer-element name="ct-results-comparison" attributes="type expectedUrl actualUrl diffUrl">
+ <template>
+ <style>
+ .main-content {
+ display: flex;
+ flex-wrap: wrap;
+ width: 100%;
+ }
+
+ .main-content > * {
+ flex: 1;
+ min-width: 300px;
+ }
+ </style>
+
+ <div class="main-content">
+ <div>
+ <h2>Expected</h2>
+ <ct-test-output type="{{ type }}" url="{{ expectedUrl }}"
+ on-mouseout="{{ _handleMouseOut }}" on-mousemove="{{ _handleMouseMove }}"></ct-test-output>
+ </div>
+ <div>
+ <h2>Actual</h2>
+ <ct-test-output type="{{ type }}" url="{{ actualUrl }}"
+ on-mouseout="{{ _handleMouseOut }}" on-mousemove="{{ _handleMouseMove }}"></ct-test-output>
+ </div>
+ <div>
+ <h2>Diff</h2>
+ <ct-test-output type="{{ type }}" url="{{ diffUrl }}"
+ on-mouseout="{{ _handleMouseOut }}" on-mousemove="{{ _handleMouseMove }}"></ct-test-output>
+ </div>
+ </div>
+
+ <template if="{{ _zoomPosition }}">
+ <ct-results-comparison-zoomer
+ expectedUrl="{{ expectedUrl }}"
+ actualUrl="{{ actualUrl }}"
+ diffUrl="{{ diffUrl }}"
+ position="{{ _zoomPosition }}"></ct-results-comparison-zoomer>
</template>
+ </template>
+ <script>
+ Polymer({
+ type: '',
+ expectedUrl: '',
+ actualUrl: '',
+ diffUrl: '',
+ _zoomPosition: null,
+
+ typeChanged: function() {
+ this._zoomPosition = null;
+ },
+
+ _handleMouseOut: function(e) {
+ this._zoomPosition = null;
+ },
+
+ _handleMouseMove: function(e) {
+ if (this.type != 'image')
+ return;
+
+ // FIXME: This assumes that the ct-test-output only contains an image.
+ var targetLocation = e.target.getBoundingClientRect();
+ // FIXME: Use a proper model class instead of a dumb object.
+ this._zoomPosition = {
+ x: (e.clientX - targetLocation.left) / targetLocation.width,
+ y: (e.clientY - targetLocation.top) / targetLocation.height,
+ };
+ },
+ });
+ </script>
</polymer-element>
« no previous file with comments | « Tools/GardeningServer/run-unittests.html ('k') | Tools/GardeningServer/ui/ct-results-comparison-tests.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698