Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 403983002: Port pixelzoomer.js/css to ct-results-comparison. (Closed)

Created:
6 years, 5 months ago by ojan
Modified:
6 years, 5 months ago
CC:
blink-reviews
Project:
blink
Visibility:
Public.

Description

Port pixelzoomer.js/css to ct-results-comparison. This broke when I changed the results comparison to use polymer components. This isn't 100% the same as the old pixelzoomer code. I took this as an opportunity to simplify it. Also, change the 4-space indent to 2-space indent and replace endOfMicroTask calls with requestAnimationFrame to match the rest of the codebase. NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178536

Patch Set 1 #

Patch Set 2 : make component. add tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+303 lines, -50 lines) Patch
M Tools/GardeningServer/run-unittests.html View 1 1 chunk +2 lines, -1 line 0 comments Download
M Tools/GardeningServer/ui/ct-results-comparison.html View 1 1 chunk +71 lines, -26 lines 0 comments Download
M Tools/GardeningServer/ui/ct-results-comparison-tests.html View 1 1 chunk +56 lines, -23 lines 0 comments Download
A Tools/GardeningServer/ui/ct-results-comparison-zoomer.html View 1 1 chunk +114 lines, -0 lines 0 comments Download
A Tools/GardeningServer/ui/ct-results-comparison-zoomer-tests.html View 1 1 chunk +59 lines, -0 lines 0 comments Download
M Tools/GardeningServer/ui/ct-test-output.html View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
ojan
This patch and leviw's revisions notification patch are the final bits to be feature complete ...
6 years, 5 months ago (2014-07-20 03:27:57 UTC) #1
abarth-chromium
Wow, so much cleaner. This can't be a separate component that you add to ct-results-comparison?
6 years, 5 months ago (2014-07-20 16:48:12 UTC) #2
ojan
This is ready for review now.
6 years, 5 months ago (2014-07-20 23:31:35 UTC) #3
abarth-chromium
LGTM
6 years, 5 months ago (2014-07-21 06:12:50 UTC) #4
abarth-chromium
The CQ bit was checked by abarth@chromium.org
6 years, 5 months ago (2014-07-21 06:12:56 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ojan@chromium.org/403983002/20001
6 years, 5 months ago (2014-07-21 06:13:04 UTC) #6
commit-bot: I haz the power
6 years, 5 months ago (2014-07-21 06:13:29 UTC) #7
Message was sent while issue was closed.
Change committed as 178536

Powered by Google App Engine
This is Rietveld 408576698