Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 403963002: Remove remaining overrides of View::GetEventHandlerForRect() (Closed)

Created:
6 years, 5 months ago by tdanderson
Modified:
6 years, 5 months ago
Reviewers:
sky
CC:
chromium-reviews, tdanderson+views_chromium.org, benquan, tfarina, Dane Wallinga, dyu1, estade+watch_chromium.org, ben+views_chromium.org, James Su, Ilya Sherman, rouslan+autofillwatch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Remove remaining overrides of View::GetEventHandlerForRect() Remove the remaining overrides of View::GetEventHandlerForRect() and instead implement ViewTargeterDelegate::TargetForRect(). Make View::GetEventHandlerForRect() non-virtual. BUG=391845 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284525

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+177 lines, -117 lines) Patch
M chrome/browser/ui/views/autofill/autofill_dialog_views.h View 3 chunks +7 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/autofill/autofill_dialog_views.cc View 3 chunks +8 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/autofill/decorated_textfield.h View 3 chunks +7 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/autofill/decorated_textfield.cc View 4 chunks +14 lines, -7 lines 0 comments Download
M chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.h View 4 chunks +6 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.cc View 4 chunks +10 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab.cc View 2 chunks +18 lines, -15 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab_strip.h View 4 chunks +6 lines, -1 line 0 comments Download
M chrome/browser/ui/views/tabs/tab_strip.cc View 4 chunks +34 lines, -29 lines 0 comments Download
M ui/message_center/views/notification_view.h View 4 chunks +9 lines, -3 lines 0 comments Download
M ui/message_center/views/notification_view.cc View 4 chunks +29 lines, -22 lines 0 comments Download
M ui/views/view.h View 1 chunk +1 line, -2 lines 0 comments Download
M ui/views/window/non_client_view.h View 3 chunks +4 lines, -2 lines 0 comments Download
M ui/views/window/non_client_view.cc View 3 chunks +24 lines, -20 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
tdanderson
Scott, can you please take a look?
6 years, 5 months ago (2014-07-21 15:32:15 UTC) #1
sky
LGTM
6 years, 5 months ago (2014-07-21 16:57:20 UTC) #2
tdanderson
The CQ bit was checked by tdanderson@chromium.org
6 years, 5 months ago (2014-07-21 19:03:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tdanderson@chromium.org/403963002/1
6 years, 5 months ago (2014-07-21 19:04:45 UTC) #4
commit-bot: I haz the power
6 years, 5 months ago (2014-07-21 22:46:51 UTC) #5
Message was sent while issue was closed. 
Change committed as 284525

Powered by Google App Engine
This is Rietveld 408576698