Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Issue 403923003: Reland "Use language-specific street address line separators." (Closed)

Created:
6 years, 5 months ago by please use gerrit instead
Modified:
6 years, 5 months ago
Reviewers:
aruslan, Evan Stade
CC:
chromium-reviews, benquan, browser-components-watch_chromium.org, Dane Wallinga, dyu1, estade+watch_chromium.org, Ilya Sherman, rouslan+autofillwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Reland "Use language-specific street address line separators." This patch fixes a past-the-end iterator and relands https://crrev.com/284335, which was reverted in https://crrev.com/284340. TBR=estade@chromium.org,aruslan@chromium.org BUG=270261 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284354

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+129 lines, -65 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/android/autofill/autofill_dialog_controller_android.cc View 2 chunks +9 lines, -4 lines 0 comments Download
M chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/autofill/data_model_wrapper.cc View 1 chunk +1 line, -0 lines 0 comments Download
M components/autofill/core/browser/autofill_field.h View 1 chunk +5 lines, -3 lines 0 comments Download
M components/autofill/core/browser/autofill_field.cc View 4 chunks +15 lines, -5 lines 0 comments Download
M components/autofill/core/browser/autofill_field_unittest.cc View 24 chunks +77 lines, -45 lines 0 comments Download
M components/autofill/core/browser/autofill_manager.cc View 3 chunks +13 lines, -4 lines 0 comments Download
M components/autofill/core/browser/form_structure.h View 1 chunk +3 lines, -1 line 0 comments Download
M components/autofill/core/browser/form_structure.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/libaddressinput/README.chromium View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
please use gerrit instead
TBR-ing Evan and Ruslan for reland.
6 years, 5 months ago (2014-07-19 20:04:29 UTC) #1
please use gerrit instead
The CQ bit was checked by rouslan@chromium.org
6 years, 5 months ago (2014-07-19 20:04:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rouslan@chromium.org/403923003/1
6 years, 5 months ago (2014-07-19 20:05:20 UTC) #3
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 5 months ago (2014-07-19 23:25:17 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-20 00:34:37 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered_tests/builds/172913)
6 years, 5 months ago (2014-07-20 00:34:38 UTC) #6
please use gerrit instead
The CQ bit was checked by rouslan@chromium.org
6 years, 5 months ago (2014-07-20 00:47:26 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rouslan@chromium.org/403923003/1
6 years, 5 months ago (2014-07-20 00:48:22 UTC) #8
commit-bot: I haz the power
6 years, 5 months ago (2014-07-20 02:24:41 UTC) #9
Message was sent while issue was closed.
Change committed as 284354

Powered by Google App Engine
This is Rietveld 408576698