Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Unified Diff: ui/gfx/font_render_params_android.cc

Issue 403923002: Make GetCustomFontRenderParams() pass font style. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: apply review feedback Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/gfx/font_render_params.h ('k') | ui/gfx/font_render_params_linux.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/gfx/font_render_params_android.cc
diff --git a/ui/gfx/font_render_params_android.cc b/ui/gfx/font_render_params_android.cc
index 0d5650042fb151378ebead17b5fa8b9e848f9c7b..b67ea1840dfd6a95c7ccaf60f9ceb010a55756c1 100644
--- a/ui/gfx/font_render_params_android.cc
+++ b/ui/gfx/font_render_params_android.cc
@@ -10,43 +10,43 @@ namespace gfx {
namespace {
-// Initializes |params| with the system's default settings.
-void LoadDefaults(FontRenderParams* params) {
- params->antialiasing = true;
- params->autohinter = true;
- params->use_bitmaps = true;
- params->subpixel_rendering = FontRenderParams::SUBPIXEL_RENDERING_NONE;
+// Returns the system's default settings.
+FontRenderParams LoadDefaults() {
+ FontRenderParams params;
+ params.antialiasing = true;
+ params.autohinter = true;
+ params.use_bitmaps = true;
+ params.subpixel_rendering = FontRenderParams::SUBPIXEL_RENDERING_NONE;
// Use subpixel text positioning to keep consistent character spacing when
// the page is scaled by a fractional factor.
- params->subpixel_positioning = true;
+ params.subpixel_positioning = true;
// Slight hinting renders much better than normal hinting on Android.
- params->hinting = FontRenderParams::HINTING_SLIGHT;
+ params.hinting = FontRenderParams::HINTING_SLIGHT;
+
+ return params;
}
} // namespace
const FontRenderParams& GetDefaultFontRenderParams() {
- static bool loaded_defaults = false;
- static FontRenderParams default_params;
- if (!loaded_defaults)
- LoadDefaults(&default_params);
- loaded_defaults = true;
+ static FontRenderParams default_params = LoadDefaults();
return default_params;
}
+const FontRenderParams& GetDefaultWebKitFontRenderParams() {
+ return GetDefaultFontRenderParams();
+}
+
FontRenderParams GetCustomFontRenderParams(
bool for_web_contents,
const std::vector<std::string>* family_list,
const int* pixel_size,
const int* point_size,
+ const int* style,
std::string* family_out) {
NOTIMPLEMENTED();
return GetDefaultFontRenderParams();
}
-const FontRenderParams& GetDefaultWebKitFontRenderParams() {
- return GetDefaultFontRenderParams();
-}
-
} // namespace gfx
« no previous file with comments | « ui/gfx/font_render_params.h ('k') | ui/gfx/font_render_params_linux.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698