Make GetCustomFontRenderParams() pass font style.

ui/gfx/platform_font_pango.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/gfx/platform_font_pango.h"
 
 #include <fontconfig/fontconfig.h>
 #include <pango/pango.h>
 
 #include <algorithm>
@@ skipping 76 matching lines @@
     if (!description || !description->get())
       description.reset(new ScopedPangoFontDescription("sans 10"));
     default_font_ = new Font(description->get());
   }
 
   InitFromPlatformFont(
       static_cast<PlatformFontPango*>(default_font_->platform_font()));
 }
 
 PlatformFontPango::PlatformFontPango(NativeFont native_font) {
+  std::string font_family;
+  std::vector<std::string> family_names;
+  base::SplitString(pango_font_description_get_family(native_font), ',',
+                    &family_names);
+
   const int pango_size =
       pango_font_description_get_size(native_font) / PANGO_SCALE;
   const bool pango_using_pixels =
       pango_font_description_get_size_is_absolute(native_font);
 
-  std::string font_family;
-  std::vector<std::string> family_names;
-  base::SplitString(pango_font_description_get_family(native_font), ',',
-                    &family_names);
-  const FontRenderParams params = GetCustomFontRenderParams(
-      false, &family_names,
-      pango_using_pixels ? &pango_size : NULL /* pixel_size */,
-      !pango_using_pixels ? &pango_size : NULL /* point_size */,
-      &font_family);
-
   int style = 0;
   // TODO(davemoore) What should we do about other weights? We currently only
   // support BOLD.
   if (pango_font_description_get_weight(native_font) == PANGO_WEIGHT_BOLD)
     style |= gfx::Font::BOLD;
   // TODO(davemoore) What about PANGO_STYLE_OBLIQUE?
   if (pango_font_description_get_style(native_font) == PANGO_STYLE_ITALIC)
     style |= gfx::Font::ITALIC;
 
+  const FontRenderParams params = GetCustomFontRenderParams(
+      false, &family_names,
+      pango_using_pixels ? &pango_size : NULL /* pixel_size */,
+      !pango_using_pixels ? &pango_size : NULL /* point_size */,
+      &style, &font_family);
+
   InitFromDetails(skia::RefPtr<SkTypeface>(), font_family,
                   gfx::GetPangoFontSizeInPixels(native_font), style, params);
 }
 
 PlatformFontPango::PlatformFontPango(const std::string& font_name,
                                      int font_size_pixels) {
   const std::vector<std::string> font_list(1, font_name);
+  const int style = Font::NORMAL;
   const FontRenderParams params = GetCustomFontRenderParams(
-      false, &font_list, &font_size_pixels, NULL, NULL);
+      false, &font_list, &font_size_pixels, NULL, &style, NULL);
   InitFromDetails(skia::RefPtr<SkTypeface>(), font_name, font_size_pixels,
-                  SkTypeface::kNormal, params);

[Daniel Erat, 2014/07/19 01:34:44]

this was a bug, but luckily both enums use 0 for "normal"

[msw, 2014/07/19 03:11:52]

Acknowledged; thanks for fixing it.

+                  style, params);
 }
 
 double PlatformFontPango::underline_position() const {
   const_cast<PlatformFontPango*>(this)->InitPangoMetrics();
   return underline_position_pixels_;
 }
 
 double PlatformFontPango::underline_thickness() const {
   const_cast<PlatformFontPango*>(this)->InitPangoMetrics();
   return underline_thickness_pixels_;
@@ skipping 20 matching lines @@
 
 Font PlatformFontPango::DeriveFont(int size_delta, int style) const {
   const int new_size = font_size_pixels_ + size_delta;
   DCHECK_GT(new_size, 0);
 
   // If the style changed, we may need to load a new face.
   std::string new_family = font_family_;
   skia::RefPtr<SkTypeface> typeface =
       (style == style_) ? typeface_ : CreateSkTypeface(style, &new_family);
 
-  // If the size or family changed, get updated rendering settings.
-  FontRenderParams render_params = font_render_params_;
-  if (size_delta != 0 || new_family != font_family_) {
-    const std::vector<std::string> family_list(1, new_family);
-    render_params = GetCustomFontRenderParams(
-        false, &family_list, &new_size, NULL, NULL);
-  }
+  const std::vector<std::string> family_list(1, new_family);
+  const FontRenderParams render_params = GetCustomFontRenderParams(
+      false, &family_list, &new_size, NULL, &style, NULL);
 
   return Font(new PlatformFontPango(typeface,
                                     new_family,
                                     new_size,
                                     style,
                                     render_params));
 }
 
 int PlatformFontPango::GetHeight() const {
   return height_pixels_;
@@ skipping 183 matching lines @@
   return new PlatformFontPango(native_font);
 }
 
 // static
 PlatformFont* PlatformFont::CreateFromNameAndSize(const std::string& font_name,
                                                   int font_size) {
   return new PlatformFontPango(font_name, font_size);
 }
 
 }  // namespace gfx