Cleanup/ Use ExtensionRegistry from app_sync_ui_state.*

chrome/browser/ui/ash/app_sync_ui_state.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_ASH_APP_SYNC_UI_STATE_H_
 #define CHROME_BROWSER_UI_ASH_APP_SYNC_UI_STATE_H_
 
 #include "base/basictypes.h"
 #include "base/compiler_specific.h"
 #include "base/observer_list.h"
 #include "base/timer/timer.h"
 #include "chrome/browser/sync/profile_sync_service_observer.h"
 #include "components/keyed_service/core/keyed_service.h"
 #include "content/public/browser/notification_observer.h"
 #include "content/public/browser/notification_registrar.h"
+#include "extensions/browser/extension_registry_observer.h"
 
 class AppSyncUIStateObserver;
 class Profile;
 class ProfileSyncService;
 
+namespace extensions {
+class ExtensionRegistry;
+}
+
 // AppSyncUIState watches app sync and installation and change its state
 // accordingly. Its status is for UI display only. It only watches for new
 // normal user profile (i.e. it does not watch for guest profile or exsiting
 // user profile) and lasts for at the most 1 minute.
 class AppSyncUIState : public KeyedService,
-                       public content::NotificationObserver,
-                       public ProfileSyncServiceObserver {
+                       public ProfileSyncServiceObserver,
+                       public extensions::ExtensionRegistryObserver {
  public:
   enum Status {
     STATUS_NORMAL,
     STATUS_SYNCING,    // Syncing apps or installing synced apps.
     STATUS_TIMED_OUT,  // Timed out when waiting for sync to finish.
   };
 
   // Returns the instance for the given |profile|. It's a convenience wrapper
   // of AppSyncUIStateFactory::GetForProfile. Note this function returns
   // NULL if ShouldObserveAppSyncForProfile returns false for |profile|.
@@ skipping 17 matching lines @@
   void SetStatus(Status status);
 
   // Checks and sets app sync status. If sync has not setup, do nothing. If sync
   // is completed and there is no pending synced extension install, sets
   // STATUS_SYNCING. Otherwise, sets STATUS_NORMAL.
   void CheckAppSync();
 
   // Invoked when |max_syncing_status_timer_| fires.
   void OnMaxSyncingTimer();
 
-  // content::NotificationObserver overrides:
-  virtual void Observe(int type,
-                       const content::NotificationSource& source,
-                       const content::NotificationDetails& details) OVERRIDE;
+  // extensions::ExtensionRegistryObserver overrides:

[James Cook, 2014/07/22 16:29:24]

nit: Change this to match the order of the interfaces in the class
AppSyncUIState : public... declaration.  So list ProfileSyncServiceObserver
overrides first.

[limasdf, 2014/07/22 16:38:10]

Done.

+  virtual void OnExtensionLoaded(
+      content::BrowserContext* browser_context,
+      const extensions::Extension* extension) OVERRIDE;
 
   // ProfileSyncServiceObserver overrides:
   virtual void OnStateChanged() OVERRIDE;
 
-  content::NotificationRegistrar registrar_;
-
   Profile* profile_;
   ProfileSyncService* sync_service_;
 
   // Timer to limit how much time STATUS_SYNCING is allowed.
   base::OneShotTimer<AppSyncUIState> max_syncing_status_timer_;
 
   Status status_;
   ObserverList<AppSyncUIStateObserver> observers_;
 
+  extensions::ExtensionRegistry* extension_registry_;
+
   DISALLOW_COPY_AND_ASSIGN(AppSyncUIState);
 };
 
 #endif  // CHROME_BROWSER_UI_ASH_APP_SYNC_UI_STATE_H_