Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 403843002: Convert some layout tests to text-based-repaint tests (Closed)

Created:
6 years, 5 months ago by Xianzhu
Modified:
6 years, 5 months ago
CC:
blink-reviews
Project:
blink
Visibility:
Public.

Description

Convert some layout tests to text-based-repaint tests - less code - able to use features of text-based-repaint.js Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178496

Patch Set 1 : #

Patch Set 2 : Rebase tests (due to removal of <pre>) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -229 lines) Patch
M LayoutTests/compositing/repaint/clipping-should-not-repaint-composited-descendants.html View 2 chunks +5 lines, -22 lines 0 comments Download
M LayoutTests/compositing/repaint/clipping-should-not-repaint-composited-descendants-expected.txt View 1 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/compositing/repaint/fixed-pos-inside-composited-intermediate-layer.html View 4 chunks +4 lines, -25 lines 0 comments Download
M LayoutTests/compositing/repaint/fixed-pos-with-composited-child.html View 3 chunks +4 lines, -24 lines 0 comments Download
M LayoutTests/compositing/repaint/fixed-pos-with-composited-child-expected.txt View 1 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/compositing/repaint/resize-repaint.html View 1 chunk +8 lines, -22 lines 0 comments Download
M LayoutTests/compositing/squashing/remove-squashed-layer-plus-move.html View 1 chunk +4 lines, -17 lines 0 comments Download
M LayoutTests/compositing/squashing/repaint-overflow-scrolled-squashed-content.html View 1 chunk +4 lines, -19 lines 0 comments Download
M LayoutTests/compositing/squashing/repaint-via-layout-offset.html View 2 chunks +4 lines, -24 lines 0 comments Download
M LayoutTests/compositing/squashing/resize-squashing-layer-that-needs-full-repaint.html View 1 chunk +4 lines, -21 lines 0 comments Download
M LayoutTests/compositing/squashing/squashing-inside-preserve-3d-element.html View 2 chunks +4 lines, -17 lines 0 comments Download
M LayoutTests/compositing/squashing/tricky-element-removal-crash.html View 1 chunk +4 lines, -17 lines 0 comments Download
M LayoutTests/fast/repaint/paint-invalidation-with-opacity.html View 1 chunk +5 lines, -17 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Xianzhu
Will rebaseline if needed after try.
6 years, 5 months ago (2014-07-18 20:25:35 UTC) #1
chrishtr
lgtm \o/
6 years, 5 months ago (2014-07-18 21:02:39 UTC) #2
Xianzhu
The CQ bit was checked by wangxianzhu@chromium.org
6 years, 5 months ago (2014-07-18 21:18:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wangxianzhu@chromium.org/403843002/40001
6 years, 5 months ago (2014-07-18 21:19:09 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...
6 years, 5 months ago (2014-07-18 22:34:36 UTC) #5
commit-bot: I haz the power
6 years, 5 months ago (2014-07-18 23:49:12 UTC) #6
Message was sent while issue was closed.
Change committed as 178496

Powered by Google App Engine
This is Rietveld 408576698