Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 40383005: Disable WebrtcBrowserTests on Android (Closed)

Created:
7 years, 2 months ago by gone
Modified:
7 years, 2 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, feature-media-reviews_chromium.org, jam, darin-cc_chromium.org
Visibility:
Public.

Description

Disable WebrtcBrowserTests on Android They're failing on multiple Android FYI bots on the waterfall. NOTRY=true BUG=311348 TBR=mallinath@chromium.org,fischman Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=230850

Patch Set 1 #

Patch Set 2 : Adding http #

Patch Set 3 : Change disabling method #

Total comments: 1

Patch Set 4 : Nit fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M build/android/pylib/gtest/filter/content_browsertests_disabled View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
xhwang
You may want to disable it here: build/android/pylib/gtest/filter/content_browsertests_disabled BTW, I am not the correct owner ...
7 years, 2 months ago (2013-10-24 21:25:55 UTC) #1
Mallinath (Gone from Chromium)
On 2013/10/24 21:25:55, xhwang wrote: > You may want to disable it here: > build/android/pylib/gtest/filter/content_browsertests_disabled ...
7 years, 2 months ago (2013-10-24 21:33:20 UTC) #2
gone
Swapped around how it was being disabled (thanks!). Submitting to help make the bot greener.
7 years, 2 months ago (2013-10-24 22:19:26 UTC) #3
xhwang
lgtm % nit https://codereview.chromium.org/40383005/diff/110001/build/android/pylib/gtest/filter/content_browsertests_disabled File build/android/pylib/gtest/filter/content_browsertests_disabled (right): https://codereview.chromium.org/40383005/diff/110001/build/android/pylib/gtest/filter/content_browsertests_disabled#newcode112 build/android/pylib/gtest/filter/content_browsertests_disabled:112: WebrtcBrowserTest.CallWithSctpDataAndMedia can you move this up ...
7 years, 2 months ago (2013-10-24 22:20:30 UTC) #4
gone
On 2013/10/24 22:20:30, xhwang wrote: > lgtm % nit > > https://codereview.chromium.org/40383005/diff/110001/build/android/pylib/gtest/filter/content_browsertests_disabled > File build/android/pylib/gtest/filter/content_browsertests_disabled ...
7 years, 2 months ago (2013-10-24 22:21:10 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dfalcantara@chromium.org/40383005/180001
7 years, 2 months ago (2013-10-24 22:25:06 UTC) #6
commit-bot: I haz the power
7 years, 2 months ago (2013-10-24 22:33:48 UTC) #7
Message was sent while issue was closed.
Change committed as 230850

Powered by Google App Engine
This is Rietveld 408576698