content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java - Issue 403823002: Merge 284152 "[Android] Fix PEN event values"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

Issue 403823002: Merge 284152 "[Android] Fix PEN event values" (Closed) Base URL: svn://svn.chromium.org/chrome/branches/1985_122/src/

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

===================================================================

--- content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java (revision 284152)

+++ content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java (working copy)

@@ -108,11 +108,11 @@

// Length of the delay (in ms) before fading in handles after the last page movement.

private static final int TEXT_HANDLE_FADE_IN_DELAY = 300;

- // These values are empirically obtained.

- private static final int SPEN_ACTION_DOWN = 11;

- private static final int SPEN_ACTION_UP = 12;

- private static final int SPEN_ACTION_MOVE = 13;

- private static final int SPEN_ACTION_CANCEL = 14;

+ // These values are obtained from Samsung.

+ private static final int SPEN_ACTION_DOWN = 211;

+ private static final int SPEN_ACTION_UP = 212;

+ private static final int SPEN_ACTION_MOVE = 213;

+ private static final int SPEN_ACTION_CANCEL = 214;

private static Boolean sIsSPenSupported;

// If the embedder adds a JavaScript interface object that contains an indirect reference to

« no previous file with comments | « no previous file | no next file » | no next file with comments »