base/synchronization/condition_variable.h - Issue 403803004: base: Enable lock dchecks with dchecks_always_on

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/synchronization/condition_variable.h

Issue 403803004: base: Enable lock dchecks with dchecks_always_on (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix condition variable too Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/synchronization/condition_variable.h

diff --git a/base/synchronization/condition_variable.h b/base/synchronization/condition_variable.h

index 4f744f80b27e54bfdee4c59e10d74c70e4c40273..5d8507d43730dbca5793d65c8a9caa582c193d2b 100644

--- a/base/synchronization/condition_variable.h

+++ b/base/synchronization/condition_variable.h

@@ -104,7 +104,7 @@ class BASE_EXPORT ConditionVariable {

#elif defined(OS_POSIX)

pthread_cond_t condition_;

pthread_mutex_t* user_mutex_;

-#if !defined(NDEBUG)

+#if !defined(NDEBUG) || defined(DCHECK_ALWAYS_ON)

base::Lock* user_lock_; // Needed to adjust shadow lock state on wait.

#endif