Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 403803003: Move mojo_bindings_java target to mojo.gyp (Closed)

Created:
6 years, 5 months ago by Chris Masone
Modified:
6 years, 5 months ago
Reviewers:
qsr
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Project:
chromium
Visibility:
Public.

Description

Move mojo_bindings_java target to mojo.gyp This target was initially defined in mojo_public.gypi, but it depends on code outside of mojo/public. Move it to mojo.gyp, where the target for code in the adjacent directory (mojo/bindings/js) is defined. BUG=None TEST=trybots Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284405

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -13 lines) Patch
M mojo/mojo.gyp View 1 chunk +11 lines, -0 lines 0 comments Download
M mojo/mojo_public.gypi View 1 chunk +0 lines, -13 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Chris Masone
6 years, 5 months ago (2014-07-21 03:43:48 UTC) #1
qsr
LGTM. Might move back to public with the associated code.
6 years, 5 months ago (2014-07-21 07:54:18 UTC) #2
Chris Masone
The CQ bit was checked by cmasone@chromium.org
6 years, 5 months ago (2014-07-21 07:58:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cmasone@chromium.org/403803003/1
6 years, 5 months ago (2014-07-21 07:59:00 UTC) #4
commit-bot: I haz the power
6 years, 5 months ago (2014-07-21 09:14:21 UTC) #5
Message was sent while issue was closed.
Change committed as 284405

Powered by Google App Engine
This is Rietveld 408576698