Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Issue 403803002: Roll dom_distiller_js (Closed)

Created:
6 years, 5 months ago by Yaron
Modified:
6 years, 5 months ago
Reviewers:
nyquist
CC:
chromium-reviews, cjhopman, kuan
Project:
chromium
Visibility:
Public.

Description

Roll dom_distiller_js Picked up changes: 047ef5d Hookup the MarkupParser into title detection. 885a0af Also track whitespace text in TextBlocks. 39ef3db Add more colors to debug output. 0577e31 Add comments about UnicodePatternGenerator ranges 805c65e Simplify iteration in *RulesClassifier fe610d7 Make debug output colorful edc26e0 Introduce a DomDistillerTestSuite for running multiple tests in one context. 7a7f948 Convert relative "poster" attribute to absolute for HTML5 video. 73225c7 Remove unused Clone method from TextDocument/TextBlock. bb65cef Don't merge non-content lists with trailing content. 3d00eba check for opacity for element visibility 79f3bae ignore invisible page links 8416ada Allow DocumentTitleMatchClassifier to match repeated titles. 8dade4b Fix id check for comment exclusion. 7f91f0d improve heuristics for tables in eval set 5fa3c95 Make DomDistiller's text-only output include all extracted text. BUG=367233, 368941, 376107, 378385, 380792, 381973 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284208

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+527 lines, -516 lines) Patch
M third_party/dom_distiller_js/README.chromium View 1 chunk +1 line, -1 line 0 comments Download
M third_party/dom_distiller_js/package/js/domdistiller.js View 1 chunk +526 lines, -515 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Yaron
6 years, 5 months ago (2014-07-18 17:42:52 UTC) #1
nyquist
lgtm
6 years, 5 months ago (2014-07-18 17:52:12 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yfriedman@chromium.org/403803002/1
6 years, 5 months ago (2014-07-18 17:53:38 UTC) #3
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 5 months ago (2014-07-18 19:55:05 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-18 20:21:19 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered_tests/builds/172650)
6 years, 5 months ago (2014-07-18 20:21:20 UTC) #6
Yaron
The CQ bit was checked by yfriedman@chromium.org
6 years, 5 months ago (2014-07-18 20:34:27 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yfriedman@chromium.org/403803002/1
6 years, 5 months ago (2014-07-18 20:36:36 UTC) #8
commit-bot: I haz the power
6 years, 5 months ago (2014-07-18 21:37:42 UTC) #9
Message was sent while issue was closed.
Change committed as 284208

Powered by Google App Engine
This is Rietveld 408576698