Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(380)

Issue 403793003: Encoding API: Enable test of ibm866 (Closed)

Created:
6 years, 5 months ago by jsbell
Modified:
6 years, 5 months ago
Reviewers:
jungshik at Google
CC:
blink-reviews
Project:
blink
Visibility:
Public.

Description

Encoding API: Enable test of ibm866 Following Chromium r284167 the "ibm866" encoding is supported and we can enable the TextDecoder test for it. R=jshin@chromium.org BUG=277023 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178502

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M LayoutTests/fast/encoding/api/ascii-supersets-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/encoding/api/resources/shared.js View 3 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
jsbell
jshin@ - please take a look?
6 years, 5 months ago (2014-07-18 19:25:35 UTC) #1
jungshik at Google
On 2014/07/18 19:25:35, jsbell wrote: > jshin@ - please take a look? I was making ...
6 years, 5 months ago (2014-07-18 23:57:13 UTC) #2
jsbell
The CQ bit was checked by jsbell@chromium.org
6 years, 5 months ago (2014-07-19 00:03:13 UTC) #3
jsbell
On 2014/07/18 23:57:13, Jungshik Shin wrote: > On 2014/07/18 19:25:35, jsbell wrote: > > jshin@ ...
6 years, 5 months ago (2014-07-19 00:03:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jsbell@chromium.org/403793003/1
6 years, 5 months ago (2014-07-19 00:03:54 UTC) #5
commit-bot: I haz the power
6 years, 5 months ago (2014-07-19 00:06:44 UTC) #6
Message was sent while issue was closed.
Change committed as 178502

Powered by Google App Engine
This is Rietveld 408576698