[Mac] Hide all shims when Chrome is hidden.

[Mac] Hide all shims when Chrome is hidden.

Since hiding Chrome hides all apps, this informs the shims that their
app is hidden. This ensures that a unhide is fired when the shim is next
focused.

BUG=355397
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284622

[tapted, 2014-07-18 06:24:34]

lgtm with a nit

https://codereview.chromium.org/403743002/diff/1/apps/app_shim/extension_app_...
File apps/app_shim/extension_app_shim_handler_mac.cc (right):

https://codereview.chromium.org/403743002/diff/1/apps/app_shim/extension_app_...
apps/app_shim/extension_app_shim_handler_mac.cc:300: ExtensionAppShimHandler*
handler = g_browser_process->platform_part()
nit: WDYT about adding a GetHandler/GetInstance() private static helper
function? there's 4 other occurrences of this code now (and clang-format now
wants the format to be different :p)

[jackhou1, 2014-07-21 01:11:27]

https://codereview.chromium.org/403743002/diff/1/apps/app_shim/extension_app_...
File apps/app_shim/extension_app_shim_handler_mac.cc (right):

https://codereview.chromium.org/403743002/diff/1/apps/app_shim/extension_app_...
apps/app_shim/extension_app_shim_handler_mac.cc:300: ExtensionAppShimHandler*
handler = g_browser_process->platform_part()
On 2014/07/18 06:24:34, tapted wrote:
> nit: WDYT about adding a GetHandler/GetInstance() private static helper
> function? there's 4 other occurrences of this code now (and clang-format now
> wants the format to be different :p)

Done.

[jackhou1, 2014-07-21 01:35:32]

rsesek, could you please review app_controller_mac.mm?

[Robert Sesek, 2014-07-21 15:17:10]

LGTM

[jackhou1, 2014-07-21 22:40:21]

sky, could you please review for OWNERS in chrome/browser/?

[sky, 2014-07-21 22:41:15]

ДПЕЬ

[sky, 2014-07-21 22:41:27]

By which I mean LGTM

[jackhou1, 2014-07-21 22:42:30]

The CQ bit was checked by jackhou@chromium.org

[commit-bot: I haz the power, 2014-07-21 22:43:46]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jackhou@chromium.org/403743002/20001

[commit-bot: I haz the power, 2014-07-21 23:27:43]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_aosp on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/9...)
  android_chromium_gn_compile_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_c...)
  android_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/bui...)
  android_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg/builds/20...)
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
  ios_dbg_simulator on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_dbg_simulator/bui...)
  ios_rel_device on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device/builds...)
  ios_rel_device_ninja on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/...)
  linux_chromium_chromeos_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_...)
  linux_chromium_gn_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel...)
  linux_chromium_rel_swarming on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel_sw...)
  mac_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_compile_...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
  win8_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win8_chromium_rel/bui...)
  win_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_compile_...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/31250)

[commit-bot: I haz the power, 2014-07-21 23:29:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-21 23:29:33]

Try jobs failed on following builders:
  ios_dbg_simulator on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_dbg_simulator/bui...)
  ios_rel_device on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device/builds...)
  ios_rel_device_ninja on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/...)
  mac_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_compile_...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/31265)

[jackhou1, 2014-07-22 01:05:36]

The CQ bit was checked by jackhou@chromium.org

[commit-bot: I haz the power, 2014-07-22 01:06:45]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jackhou@chromium.org/403743002/40001

[commit-bot: I haz the power, 2014-07-22 04:10:14]

Change committed as 284622