Add several repaint tests in case of table resize

Source/core/rendering/RenderTable.cpp

 /*
  * Copyright (C) 1997 Martin Jones (mjones@kde.org)
  *           (C) 1997 Torben Weis (weis@kde.org)
  *           (C) 1998 Waldo Bastian (bastian@kde.org)
  *           (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2013 Apple Inc. All rights reserved.
  * Copyright (C) 2006 Alexey Proskuryakov (ap@nypop.com)
  *
  * This library is free software; you can redistribute it and/or
@@ skipping 401 matching lines @@
     SubtreeLayoutScope layouter(*this);
 
     // If any table section moved vertically, we will just repaint everything from that
     // section down (it is quite unlikely that any of the following sections
     // did not shift).
     bool sectionMoved = false;
     LayoutUnit movedSectionLogicalTop = 0;
     {
         LayoutState state(*this, locationOffset());
 
+        LayoutUnit oldLogicalHeight = logicalHeight();
         setLogicalHeight(0);
 
         LayoutUnit oldLogicalWidth = logicalWidth();
         updateLogicalWidth();
 
         if (logicalWidth() != oldLogicalWidth) {
             for (unsigned i = 0; i < m_captions.size(); i++)
                 layouter.setNeedsLayout(m_captions[i]);
         }
         // FIXME: The optimisation below doesn't work since the internal table
@@ skipping 113 matching lines @@
         // table can be containing block of positioned elements.
         // FIXME: Only pass true if width or height changed.
         layoutPositionedObjects(true);
 
         updateLayerTransformAfterLayout();
 
         // Layout was changed, so probably borders too.
         invalidateCollapsedBorders();
 
         computeOverflow(clientLogicalBottom());
+
+        // This is needed after we optimized size-style-change not to always fully invalidate.
+        // FIXME: It would be better to let the changed cells invalidate themselves.

[dsinclair, 2014/07/23 16:57:29]

crbug?

Do you have an idea of how hard this would be do to the correct way of having
the cells do their own invalidation?

[Xianzhu, 2014/07/23 17:31:48]

Filed crbug.com/396674.
Table rendering code looks complex to me and I'm unlikely to work out an optimal
solution before M38 branch. I think if I missed the branch even if I could work
out an optimal solution it would be difficult and risky to merge because of the
complexity.

+        if (selfNeedsLayout() && (oldLogicalWidth != logicalWidth() || oldLogicalHeight != logicalHeight()))
+            setShouldDoFullPaintInvalidation(true);
     }
 
     // FIXME: This value isn't the intrinsic content logical height, but we need
     // to update the value as its used by flexbox layout. crbug.com/367324
     updateIntrinsicContentLogicalHeight(contentLogicalHeight());
 
     if (view()->layoutState()->pageLogicalHeight())
         setPageLogicalOffset(view()->layoutState()->pageLogicalOffset(*this, logicalTop()));
 
     m_columnLogicalWidthChanged = false;
@@ skipping 852 matching lines @@
 const BorderValue& RenderTable::tableEndBorderAdjoiningCell(const RenderTableCell* cell) const
 {
     ASSERT(cell->isFirstOrLastCellInRow());
     if (hasSameDirectionAs(cell->row()))
         return style()->borderEnd();
 
     return style()->borderStart();
 }
 
 }