Fix base_unittest.js

Fix base_unittest.js

This CL addresses some feedback from Jamie regarding unit test naming conventions and organizations.
1. Renames test_eventSource.js to base_unittest.js.
2. Groups the modules by class instead of by function.
3. Adds extra test cases for base.js

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284252

[kelvinp, 2014-07-18 00:56:42]

PTAL

[Jamie, 2014-07-18 02:16:05]

LGTM with nits.

For future reference, when you're renaming and modifying a file in the same CL,
it's very helpful to the reviewer if you upload a patch-set that just does the
rename, followed by one that modifies the file (or vice versa). Otherwise the
reviewer basically has to review the entire file again (and may ask for fixes to
parts you having changed as a result :D)

https://codereview.chromium.org/403663002/diff/1/remoting/webapp/unittests/ba...
File remoting/webapp/unittests/base_unittest.js (right):

https://codereview.chromium.org/403663002/diff/1/remoting/webapp/unittests/ba...
remoting/webapp/unittests/base_unittest.js:65: this.clock.tick(101);
I think this should also assert somehow that the promise is not fulfilled too
early.

https://codereview.chromium.org/403663002/diff/1/remoting/webapp/unittests/ba...
remoting/webapp/unittests/base_unittest.js:68: var source = null;
I think two blank lines between modules would aid readability, and perhaps a
comment to help separate them visually.

[kelvinp, 2014-07-18 20:24:55]

The CQ bit was checked by kelvinp@chromium.org

[commit-bot: I haz the power, 2014-07-18 20:26:28]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/kelvinp@chromium.org/403663002/20001

[commit-bot: I haz the power, 2014-07-18 23:40:10]

Change committed as 284252